Skip to content

Commit ebed26e

Browse files
r-barnesmeta-codesync[bot]
authored andcommitted
Remove double-conversion from open source projects
Summary: It's removed everywhere internally now and these projects no longer rely on double-conversion within their code. Just cleaning the dependency now. Replacement I used is 2-3x faster. Reviewed By: bigfootjon Differential Revision: D108654670 fbshipit-source-id: 22bd1b6610fb7a4815398f2b4a40adf01ea24455
1 parent d53a57c commit ebed26e

8 files changed

Lines changed: 0 additions & 67 deletions

File tree

build/fbcode_builder/getdeps/test/fixtures/expected/folly_shared_libs/getdeps_shared-libs_linux.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,6 @@ jobs:
7171
- name: Fetch cmake
7272
if: ${{ steps.paths.outputs.cmake_SOURCE }}
7373
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests cmake
74-
- name: Fetch double-conversion
75-
if: ${{ steps.paths.outputs.double-conversion_SOURCE }}
76-
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests double-conversion
7774
- name: Fetch fast_float
7875
if: ${{ steps.paths.outputs.fast_float_SOURCE }}
7976
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fast_float

build/fbcode_builder/getdeps/test/fixtures/expected/openr/getdeps_linux.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ jobs:
6868
- name: Fetch zstd
6969
if: ${{ steps.paths.outputs.zstd_SOURCE }}
7070
run: python3 build/fbcode_builder/getdeps.py fetch --no-tests zstd
71-
- name: Fetch double-conversion
72-
if: ${{ steps.paths.outputs.double-conversion_SOURCE }}
73-
run: python3 build/fbcode_builder/getdeps.py fetch --no-tests double-conversion
7471
- name: Fetch fast_float
7572
if: ${{ steps.paths.outputs.fast_float_SOURCE }}
7673
run: python3 build/fbcode_builder/getdeps.py fetch --no-tests fast_float

build/fbcode_builder/getdeps/test/fixtures/expected/rebalancer_linux/getdeps_linux.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@ jobs:
8080
- name: Fetch zstd
8181
if: ${{ steps.paths.outputs.zstd_SOURCE }}
8282
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests zstd
83-
- name: Fetch double-conversion
84-
if: ${{ steps.paths.outputs.double-conversion_SOURCE }}
85-
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests double-conversion
8683
- name: Fetch fast_float
8784
if: ${{ steps.paths.outputs.fast_float_SOURCE }}
8885
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fast_float

build/fbcode_builder/manifests/double-conversion

Lines changed: 0 additions & 26 deletions
This file was deleted.

build/fbcode_builder/manifests/double-conversion-python

Lines changed: 0 additions & 29 deletions
This file was deleted.

build/fbcode_builder/manifests/folly

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ boost
1919
libdwarf
2020
libevent
2121
libsodium
22-
double-conversion
2322
fast_float
2423
fmt
2524
lz4

build/fbcode_builder/manifests/folly-python

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ boost-python
2222
libdwarf-python
2323
libevent-python
2424
libsodium
25-
double-conversion-python
2625
fast_float
2726
fmt-python
2827
lz4-python

build/fbcode_builder/manifests/mcrouter

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ boost
2020
libevent
2121
openssl
2222
zlib
23-
double-conversion
2423

2524
[shipit.pathmap]
2625
fbcode/mcrouter/public_tld = .

0 commit comments

Comments
 (0)