Merge pull request #135 from facebook/handleLongPaths

Awesomeeee long file truncation Resolves #118

Author: pcottle

src/__tests__/expected/longFileTruncation.txt

@@ -0,0 +1,40 @@
+./hadoop-mapreduce-project/|...|eNamereallylongfileName.txt
+___________________________________________________________ 
+|===>./hadoop-mapreduce-pro|...|t/some/deeper/dir/source.py
+GGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGGG 
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+
+                                                            
+____________________________________________________________
+                                                            
+[f|A] selection, [down|j|up|k|space|b] navigation, [enter] o
+                                                            

src/__tests__/inputs/superLongFileNames.txt

@@ -0,0 +1,2 @@
+./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-client/hadoop-mapreduce-project/hadoop-mapreduce-client/LongFileNamereallylongfileName.txt
+./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-client/hadoop-mapreduce-project/hadoop-mapreduce-client/some/deeper/dir/source.py

src/__tests__/testScreen.py

@@ -103,6 +103,15 @@
         'maxY': 40
     },
     'pastScreens': [0, 1, 2, 3, 4]
+}, {
+    'name': 'longFileTruncation',
+    'input': 'superLongFileNames.txt',
+    'withAttributes': True,
+    'inputs': ['DOWN', 'f'],
+    'screenConfig': {
+        'maxX': 60,
+        'maxY': 20
+    },
 }]
 
 

src/format.py

@@ -43,6 +43,9 @@ def isSimple(self):
 class LineMatch(object):
 
     ARROW_DECORATOR = '|===>'
+    # this is inserted between long files, so it looks like
+    # ./src/foo/bar/something|...|baz/foo.py
+    TRUNCATE_DECORATOR = '|...|'
 
     def __init__(self, formattedLine, result, index, validateFileExists=False):
         self.controller = None
@@ -79,6 +82,7 @@ def __init__(self, formattedLine, result, index, validateFileExists=False):
 
         self.selected = False
         self.hovered = False
+        self.isTruncated = False
 
         # precalculate the pre, post, and match strings
         (self.beforeText, unused) = self.formattedLine.breakat(self.start)
@@ -145,7 +149,7 @@ def __str__(self):
                 + '||' + self.getAfter() + '||' +
                 str(self.num))
 
-    def updateDecoratedMatch(self):
+    def updateDecoratedMatch(self, maxLen=None):
         '''Update the cached decorated match formatted string, and
         dirty the line, if needed'''
         if self.hovered and self.selected:
@@ -164,9 +168,20 @@ def updateDecoratedMatch(self):
         if self.controller:
             self.controller.dirtyLine(self.index)
 
+        plainText = decoratorText + self.getMatch()
+        if maxLen and len(plainText) > maxLen:
+            # alright, we need to chop the ends off of our
+            # decorated match and glue them together with our
+            # truncation decorator
+            spaceAllowed = maxLen - len(self.TRUNCATE_DECORATOR)
+            midPoint = int(spaceAllowed / 2)
+            beginMatch = plainText[0:midPoint]
+            endMatch = plainText[-midPoint:len(plainText)]
+            plainText = beginMatch + self.TRUNCATE_DECORATOR + endMatch
+
         self.decoratedMatch = FormattedText(
             FormattedText.getSequenceForAttributes(*attributes) +
-            decoratorText + self.getMatch())
+            plainText)
 
     def getDecorator(self):
         if self.selected:
@@ -191,6 +206,30 @@ def output(self, printer):
         if (y < miny or y >= maxy):
             # wont be displayed!
             return
+        
+        # we dont care about the after text, but we should be able to see
+        # all of the decorated match (which means we need to see up to
+        # the end of the decoratedMatch, aka include beforeText)
+        importantTextLength = len(str(self.beforeText)) + \
+                              len(str(self.decoratedMatch))
+        spaceForPrinting = maxx - minx
+        if importantTextLength > spaceForPrinting:
+            # hrm, we need to update our decorated match to show
+            # a truncated version since right now we will print off
+            # the screen. lets also dump the beforeText for more
+            # space
+            self.updateDecoratedMatch(maxLen=spaceForPrinting)
+            self.isTruncated = True
+        else:
+            # first check what our expanded size would be:
+            expandedSize = len(str(self.beforeText)) + \
+              len(self.getMatch())
+            if expandedSize < spaceForPrinting and self.isTruncated:
+                # if the screen gets resized, we might be truncated
+                # from a previous render but **now** we have room.
+                # in that case lets expand back out
+                self.updateDecoratedMatch()
+                self.isTruncated = False
 
         maxLen = maxx - minx
         soFar = (minx, maxLen)