Fix incorrect skipping of SDKROOT-rooted frameworks

Summary:
# Context

The Apple platform compiler (clang) and linker (ld64) have a default list of framework search paths. Such search paths should not be included as part of the compiler and linker commands for two reasons:

- It's unnecessary
- It's behaviourally incorrectly when compiling Catalyst apps

As per the [docs](https://www.manpagez.com/man/1/ld64/):

> The default framework search path is `/Library/Frameworks` then `/System/Library/Frameworks`. (Note: previously, `/Network/Library/Frameworks` was at the end of the default path.  If you need that functionality, you need to explicitly add `-F/Network/Library/Frameworks`).
> ...
> The `-syslibroot` option will prepend a prefix to all search paths.

# Before

Previously, we would not include **any** framework search path rooted in `$SDKROOT`. That's incorrect because we **only** must skip `$SDKROOT`-rooted frameworks **if** they're part of the default search path as defined by the [docs](https://www.manpagez.com/man/1/ld64/).

# After

We now only skip frameworks which are already part of the default search path. This makes it possible to use the `StoreKitTest` framework located at `$SDKROOT/Developer/Library/Frameworks/StoreKitTest.framework`.

fbshipit-source-id: 9dbde3af4f9e3eb074ef59d6571807b802ca56d2

Author: milend

src/com/facebook/buck/cxx/CxxIncludePaths.java

@@ -93,7 +93,7 @@ public ImmutableList<String> getFlags(
         MoreIterables.zipAndConcat(
             Iterables.cycle("-F"),
             getFPaths().stream()
-                .filter(x -> !x.isSDKROOTFrameworkPath())
+                .filter(x -> !x.isImplicitlyIncludedInSearchPaths())
                 .map(frameworkPathTransformer)
                 .filter(Optional::isPresent)
                 .map(Optional::get)

src/com/facebook/buck/rules/coercer/FrameworkPath.java

@@ -40,6 +40,16 @@
 @BuckStyleValue
 public abstract class FrameworkPath implements Comparable<FrameworkPath>, AddsToRuleKey {
 
+  /**
+   * A list of implicitly included framework search paths relative to SDKROOT. Those paths do not
+   * require passing -F parameters when compiling and linking. All other SDKROOT framework paths
+   * require -F params.
+   */
+  private static final String[] IMPLICIT_SDKROOT_FRAMEWORK_SEARCH_PATHS =
+      new String[] {
+        "Library/Frameworks", "System/Library/Frameworks",
+      };
+
   /** The type of framework entry this object represents. */
   protected enum Type {
     /** An Xcode style {@link SourceTreePath}. */
@@ -84,6 +94,28 @@ public boolean isSDKROOTFrameworkPath() {
     return false;
   }
 
+  /**
+   * Determines whether a framework path is implicitly included as part of the compiler and linker.
+   * If a framework is implicitly included, there's no neeed
+   */
+  public boolean isImplicitlyIncludedInSearchPaths() {
+    return getSourceTreePath()
+        .map(
+            sourceTreePath -> {
+              if (sourceTreePath.getSourceTree() == PBXReference.SourceTree.SDKROOT) {
+                Path path = sourceTreePath.getPath();
+                for (String implicitPath : IMPLICIT_SDKROOT_FRAMEWORK_SEARCH_PATHS) {
+                  if (path.startsWith(implicitPath)) {
+                    return true;
+                  }
+                }
+              }
+
+              return false;
+            })
+        .orElse(false);
+  }
+
   /** Returns true if the framework is in the PLATFORM_DIR */
   public boolean isPlatformDirFrameworkPath() {
     if (getSourceTreePath().isPresent()) {

src/com/facebook/buck/swift/SwiftCompileBase.java

@@ -402,7 +402,7 @@ public ImmutableList<String> constructCompilerArgs(SourcePathResolverAdapter res
 
       argBuilder.addAll(
           Streams.concat(frameworks.stream(), cxxDeps.getFrameworkPaths().stream())
-              .filter(x -> !x.isSDKROOTFrameworkPath())
+              .filter(x -> !x.isImplicitlyIncludedInSearchPaths())
               .map(frameworkPathToSearchPath)
               .filter(Optional::isPresent)
               .map(Optional::get)

test/com/facebook/buck/apple/AppleTestIntegrationTest.java

@@ -209,6 +209,11 @@ public void testSetsFrameworkSearchPathAndLinksCorrectly() throws IOException {
     testSetsFrameworkSearchPathAndLinksCorrectlyWithTargetName("foo");
   }
 
+  @Test
+  public void testSetsFrameworkSearchPathAndLinksCorrectlyForDevFramework() throws IOException {
+    testSetsFrameworkSearchPathAndLinksCorrectlyWithTargetName("dev_framework_usage");
+  }
+
   private void testSetsFrameworkSearchPathAndLinksCorrectlyWithTargetName(String targetName)
       throws IOException {
     ProjectWorkspace workspace =

test/com/facebook/buck/apple/testdata/apple_test_framework_search_path/BUCK.fixture

@@ -7,3 +7,14 @@ apple_test(
     ],
     info_plist = "Test.plist",
 )
+
+apple_test(
+    name = "dev_framework_usage",
+    srcs = ["DevFrameworkUsage.m"],
+    frameworks = [
+        "$PLATFORM_DIR/Developer/Library/Frameworks/XCTest.framework",
+        "$SDKROOT/Developer/Library/Frameworks/StoreKitTest.framework",
+        "$SDKROOT/System/Library/Frameworks/Foundation.framework",
+    ],
+    info_plist = "Test.plist",
+)

test/com/facebook/buck/apple/testdata/apple_test_framework_search_path/DevFrameworkUsage.m

@@ -0,0 +1,13 @@
+#import <XCTest/XCTest.h>
+#import <StoreKitTest/StoreKitTest.h>
+
+@interface FooTest : XCTestCase
+@end
+
+@implementation FooTest
+
+- (void)testFoo {
+  XCTFail(@"whoops");
+}
+
+@end