Update release tool for chocolatey

Summary: Add some more documentation that chocolatey requires for packaging. Update a couple of nuspec fields.

Reviewed By: styurin

fbshipit-source-id: 365490dd23

Author: nataliejameson

tools/release/platforms/chocolatey/BUCK

@@ -1,7 +1,9 @@
-load("//programs:defs.bzl", "get_release_version")
+load("//programs:defs.bzl", "get_release_version", "get_release_timestamp")
 
 version = get_release_version()
 
+timestamp = get_release_timestamp()
+
 python_library(
     name = "build-lib",
     srcs = ["build.py"],
@@ -13,10 +15,11 @@ python_binary(
     deps = [":build-lib"],
 )
 
+export_file(name = "VERIFICATION.TXT")
+
 genrule(
     name = "chocolatey",
     srcs = [
-        "//:LICENSE",
         "//:README",
         "//programs:buck",
         "CHANGELOG.md",
@@ -26,5 +29,19 @@ genrule(
         "chocolateyUninstall.ps1",
     ],
     out = "buck.nupkg",
-    cmd = "$(exe :build) --version {} --output %OUT% --src-dir %SRCDIR%".format(version),
+    cmd = " ".join([
+        "$(exe :build)",
+        "--license-file",
+        "$(location //:LICENSE)",
+        "--verification-txt",
+        "$(location :VERIFICATION.TXT)",
+        "--version",
+        version,
+        "--timestamp",
+        timestamp,
+        "--output",
+        "%OUT%",
+        "--src-dir",
+        "%SRCDIR%",
+    ]),
 )

tools/release/platforms/chocolatey/CHANGELOG.md

@@ -1 +1 @@
-# This is replaced inside of build containers by buck release scripts. It must be present for the BUCK build rule to be evaluated.
+General bug fixes and performance fixes.

tools/release/platforms/chocolatey/VERIFICATION.txt

@@ -0,0 +1,11 @@
+VERIFICATION
+Verification is intended to assist the Chocolatey moderators and community
+in verifying that this package's contents are trustworthy.
+
+To reproduce buck.pex:
+
+- Clone the buck repository (`git clone --branch {release_version} https://github.com/facebook/buck.git buck`)
+- Build buck. The README.md included in this package explains how to do this in more detail but the simplified version is to run the following from the buck directory:
+-- ant
+-- ./bin/buck build -c buck.release_version={release_version} -c buck.release_timestamp={release_timestamp} --output buck.pex buck
+- Verify that buck.pex shas match with a tool like Powershell's `Get-Filehash`, or Chocolatey's `checksum.exe`

tools/release/platforms/chocolatey/buck.nuspec

@@ -4,13 +4,14 @@
   <metadata>
     <id>buck</id>
     <version>__REPLACE__</version>
-    <title>buck</title>
+    <title>Buck</title>
     <authors>Facebook Inc</authors>
     <projectUrl>https://buckbuild.com</projectUrl>
     <copyright>2012-present Facebook Inc</copyright>
     <licenseUrl>https://github.com/facebook/buck/blob/master/LICENSE</licenseUrl>
     <requireLicenseAcceptance>true</requireLicenseAcceptance>
     <projectSourceUrl>https://github.com/facebook/buck</projectSourceUrl>
+    <packageSourceUrl>https://github.com/facebook/buck</packageSourceUrl>
     <bugTrackerUrl>https://github.com/facebook/buck/issues</bugTrackerUrl>
     <tags>buck</tags>
     <summary>A fast multi-language build system from Facebook</summary>
@@ -22,7 +23,8 @@
     </dependencies>
   </metadata>
   <files>
-    <file src="LICENSE" target="LICENSE" />
+    <file src="LICENSE.txt" target="tools/LICENSE.txt" />
+    <file src="VERIFICATION.txt" target="tools/VERIFICATION.txt" />
     <file src="README.md" target="README.md" />
     <file src="buck.bat" target="tools/buck.bat" />
     <file src="buck.pex" target="tools/buck.pex" />

tools/release/platforms/chocolatey/build.py

@@ -11,9 +11,22 @@
 
 def parse_args(args):
     parser = argparse.ArgumentParser(description="Build buck's choco package")
+    parser.add_argument(
+        "--license-file",
+        required=True,
+        help="The original license file that needs a prefix added",
+    )
+    parser.add_argument(
+        "--verification-txt",
+        required=True,
+        help="The verification.txt template used when creating the nupkg",
+    )
     parser.add_argument(
         "--version", required=True, help="The version that is being built"
     )
+    parser.add_argument(
+        "--timestamp", required=True, help="The timestamp when the release was made"
+    )
     parser.add_argument(
         "--src-dir",
         required=True,
@@ -51,9 +64,29 @@ def build(nuspec, output):
     os.rename(glob.glob("buck.*.nupkg")[0], output)
 
 
+def write_license_file(original_license):
+    dest = "LICENSE.txt"
+    with open(original_license, "r") as fin, open(dest, "w") as fout:
+        fout.write("From: https://github.com/facebook/buck/blob/master/LICENSE\n")
+        fout.write("\n")
+        fout.write(fin.read())
+
+
+def write_verification_txt(original_verification_txt, version, timestamp):
+    dest = "VERIFICATION.txt"
+    with open(original_verification_txt, "r") as fin, open(dest, "w") as fout:
+        verification_text = fin.read().decode("utf-8")
+        verification_text = verification_text.format(
+            release_version=version, release_timestamp=timestamp
+        )
+        fout.write(verification_text)
+
+
 if __name__ == "__main__":
     args = parse_args(sys.argv[1:])
     tmp_dir = copy_files(args.src_dir)
     os.chdir(tmp_dir)
     update_nuspec("buck.nuspec", "CHANGELOG.md", args.version)
+    write_license_file(args.license_file)
+    write_verification_txt(args.verification_txt, args.version, args.timestamp)
     build("buck.nuspec", args.output)