Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Commit ac48cf5

Browse files
ttsugriyfacebook-github-bot
authored andcommitted
Do not compute compileTimeClasspathFullDeps twice.
Summary: This method is actually marked as Value.Lazy, so it's not a full recomputation, but still. Reviewed By: bobyangyf fbshipit-source-id: d8221b0100
1 parent 60c69a3 commit ac48cf5

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/com/facebook/buck/jvm/java/AbstractDefaultJavaLibraryClasspaths.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,12 @@ public ImmutableList<BuildRule> getNonClasspathDeps() {
9191
// TODO(jkeljo): When creating source-only ABIs, *some* non-classpath deps can be omitted
9292
// (basically anything that's not either source, resources, or a source-only-ABI-compatible
9393
// annotation processor).
94+
ImmutableSortedSet<BuildRule> compileTimeClasspathFullDeps = getCompileTimeClasspathFullDeps();
9495
return ImmutableList.copyOf(
9596
Iterables.concat(
96-
Sets.difference(getBuildRuleParams().getBuildDeps(), getCompileTimeClasspathFullDeps()),
97+
Sets.difference(getBuildRuleParams().getBuildDeps(), compileTimeClasspathFullDeps),
9798
Sets.difference(
98-
getCompileTimeClasspathUnfilteredFullDeps(), getCompileTimeClasspathFullDeps())));
99+
getCompileTimeClasspathUnfilteredFullDeps(), compileTimeClasspathFullDeps)));
99100
}
100101

101102
@Value.Lazy

0 commit comments

Comments
 (0)