Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
A smattering of
-Wmissing-field-initializers
fixes
Summary: r-barnes has a long-standing project to enable this globally, and I agree with it. This is my quick attempt to help. Per r-barnes's P1737775585, the top offender seems to be `static_extension_utils.cpp`, tested via: ``` buck2 build --config cxx.extra_cxxflags=-Wmissing-field-initializers \ @//mode/opt fbcode//tools/xar/facebook:make_xar ``` The next worst offender was `GlobalComputedDataProvider.cpp`: ``` buck2 build --config cxx.extra_cxxflags=-Wmissing-field-initializers \ fbcode//rim/policies:global_computed_data_provider ``` I also fixed a bunch of other stuff, roughly covered: ``` buck2 build --config cxx.extra_cxxflags=-Wmissing-field-initializers \ fbcode//cacheclient/tao/impl:config_caches \ fbcode//warm_storage/client/prod/common:context_with_cat_util \ fbcode//everstore/client/cpp/dev:everstore_client_impl \ fbcode//warm_storage/common/client/prod:context_util \ fbcode//smc/smcproxy:SmcProxyConfig \ fbcode//fbpkg/utils:fbpkg_acl_creation \ fbcode//sally/env:mem_buffer ``` Reviewed By: dtolnay Differential Revision: D70008646 fbshipit-source-id: ae56272a1c7e6297064b4c9acbe8fdc7029fca88
- Loading branch information