Do not allow $declared_deps and $declared in queries

Summary: This isn't properly supported, and is unused, so just get rid of this code that makes it not fail.

Reviewed By: iguridi

Differential Revision: D71477139

fbshipit-source-id: deb3c26bfa7601a6a4c811009951a3de00e2413d

Author: Ian Childs

app/buck2_interpreter_for_build/src/attrs/coerce/attr_type/query.rs

@@ -52,9 +52,6 @@ impl QueryAttrTypeExt for QueryAttrType {
             fn target_pattern(&mut self, pattern: &str) -> buck2_error::Result<()> {
                 // TODO(cjhopman): We could probably parse the pattern first. This would likely at least give a better error message when the query contains a non-literal target pattern.
                 // We could optimize this to do less work for duplicates, but it's generally not helpful.
-                if pattern == "$declared_deps" || pattern == "$declared" {
-                    return Ok(());
-                }
                 let label = self.ctx.coerce_providers_label(pattern)?;
 
                 /*

tests/core/query/cquery/test_cquery.py

@@ -269,7 +269,9 @@ async def test_disabling_of_execution_platforms(buck: Buck) -> None:
 
 @buck_test(data_dir="deps_query")
 async def test_declared_deps_query(buck: Buck) -> None:
-    # TODO(ianc) This should fail
-    await buck.cquery(
-        "root//:declared_deps",
+    await expect_failure(
+        buck.cquery(
+            "root//:declared_deps",
+        ),
+        stderr_regex="Invalid target pattern `\\$declared_deps` is not allowed",
     )