Commit 5965f1d
Run test discovery locally to save RE resources
Summary:
Static test listing (discovery) currently runs on Remote Execution workers even though it doesn't need to. This wastes RE resources that could be used for actual test execution. This change makes the Buck2 test orchestrator automatically select the "listing" executor override for discovery stages, so that listing runs locally when the target has `local_listing_enabled` set in its `remote_execution` dict.
The Buck2 prelude already creates a "listing" executor override with `local_enabled = True` when this field is present, but nothing was selecting it. Rather than round-tripping through labels and having tpx send the override name back, the orchestrator now directly checks for a "listing" executor override during listing stages and falls back to the default executor if none exists.
**CONTEXT**
S610793 is a sample sev caused by lack of quota for RE compute on 'some operation'(multisect). The operation here was simply listing, which can be done on local linux machine. The aim of this rollout is to optimize RE usage for test runs by shifting the listing workload for RE tests with the static listing setup to local. We expect all targets to be compatible with this.
Reviewed By: patskovn
Differential Revision: D92956543
fbshipit-source-id: 6938511df9776441ded1f8a54ee8cb5589e366a31 parent 645d140 commit 5965f1d
2 files changed
Lines changed: 11 additions & 1 deletion
File tree
- app
- buck2_build_api/src/interpreter/rule_defs/provider/builtin
- buck2_test/src
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
158 | 162 | | |
159 | 163 | | |
160 | 164 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1356 | 1356 | | |
1357 | 1357 | | |
1358 | 1358 | | |
1359 | | - | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
1360 | 1366 | | |
1361 | 1367 | | |
1362 | 1368 | | |
| |||
0 commit comments