Skip to content

Commit 6f4ba79

Browse files
Jeremy Orlowfacebook-github-bot
Jeremy Orlow
authored andcommitted
Add compiled_resource_apks to android_binary
Summary: Add compiled_resource_apks to android_binary buck targets and plumb it through to aapt2 to support shared resource libraries in fbsource. CoreRDK will soon use this feature (D74037074) Reviewed By: amaksoft, IanChilds Differential Revision: D73870141 fbshipit-source-id: 752e9d2c6c12f1e34107c1107f0ee433183bce3f
1 parent 74a4a46 commit 6f4ba79

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

prelude/android/android_binary_resources_rules.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def get_android_binary_resources_info(
7373
package_id_offset = 0,
7474
should_keep_raw_values = getattr(ctx.attrs, "aapt2_keep_raw_values", False),
7575
resource_stable_ids = getattr(ctx.attrs, "resource_stable_ids", None),
76-
compiled_resource_apks = [],
76+
compiled_resource_apks = getattr(ctx.attrs, "compiled_resource_apks", []),
7777
additional_aapt2_params = getattr(ctx.attrs, "additional_aapt_params", []),
7878
extra_filtered_resources = getattr(ctx.attrs, "extra_filtered_resources", []),
7979
locales = getattr(ctx.attrs, "locales", []) or getattr(ctx.attrs, "locales_for_binary_resources", []),

prelude/decls/android_rules.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ android_binary = prelude_rule(
208208
"build_config_values": attrs.list(attrs.string(), default = []),
209209
"build_config_values_file": attrs.option(attrs.source(), default = None),
210210
"build_string_source_map": attrs.bool(default = False),
211+
"compiled_resource_apks": attrs.list(attrs.source(), default = []),
211212
"compress_asset_libraries": attrs.bool(default = False),
212213
"contacts": attrs.list(attrs.string(), default = []),
213214
"cpu_filters": attrs.list(attrs.enum(TargetCpuType), default = []),
@@ -448,6 +449,7 @@ android_bundle = prelude_rule(
448449
"build_config_values_file": attrs.option(attrs.source(), default = None),
449450
"build_string_source_map": attrs.bool(default = False),
450451
"bundle_config_file": attrs.option(attrs.source(), default = None),
452+
"compiled_resource_apks": attrs.list(attrs.source(), default = []),
451453
"compress_asset_libraries": attrs.bool(default = False),
452454
"contacts": attrs.list(attrs.string(), default = []),
453455
"cpu_filters": attrs.list(attrs.enum(TargetCpuType), default = []),

0 commit comments

Comments
 (0)