targets: Flip default on target-hash-recursive

Summary: Previous diff deleted the last reference to recursive target hashing, telemetry also agrees with it being unused. Flip the default, I'll fix up callsites to not pass it at all afterward, then we can delete the flag

Reviewed By: AishwaryaSivaraman

Differential Revision: D98552750

fbshipit-source-id: 71e28ab1a7d0fd4e302f178d92e560b22588ba86

Author: JakobDegen

app/buck2_client/src/commands/targets.rs

@@ -165,7 +165,7 @@ pub struct TargetsCommand {
 
     /// When true, emit the hash or target node and all dependencies recursively.
     /// When false, hash only the target node.
-    #[clap(long, action = clap::ArgAction::Set, default_value = "true", conflicts_with = "streaming")]
+    #[clap(long, action = clap::ArgAction::Set, default_value = "false", conflicts_with = "streaming")]
     target_hash_recursive: bool,
 
     #[clap(flatten)]

tests/core/help/test_help_data/buck2-help-targets.golden.txt

@@ -56,7 +56,7 @@ Options:
           When true, emit the hash or target node and all dependencies recursively. When false, hash
           only the target node
 
-          [default: true]
+          [default: false]
           [possible values: true, false]
 
   -A, --output-all-attributes

tests/core/help/test_help_data/buck2-help-utargets.golden.txt

@@ -59,7 +59,7 @@ Options:
           When true, emit the hash or target node and all dependencies recursively. When false, hash
           only the target node
 
-          [default: true]
+          [default: false]
           [possible values: true, false]
 
   -A, --output-all-attributes

tests/core/targets_command/test_unconfigured_target_hashing.py

@@ -34,6 +34,7 @@ async def assert_hashes(
         "--json",
         "--target-hash-file-mode",
         "PATHS_ONLY",
+        "--target-hash-recursive=true",
     )
 
     modified_result = await buck.targets(
@@ -42,6 +43,7 @@ async def assert_hashes(
         "--json",
         "--target-hash-file-mode",
         "PATHS_ONLY",
+        "--target-hash-recursive=true",
         "--target-hash-modified-paths",
         modified_path,
     )

tests/e2e/targets_command/test_targets.py

@@ -59,6 +59,7 @@ async def test_configured_target_hashing(
         "--json",
         "--target-hash-file-mode",
         "PATHS_ONLY",
+        "--target-hash-recursive=true",
     )
 
     # Modify a target
@@ -68,6 +69,7 @@ async def test_configured_target_hashing(
         "--json",
         "--target-hash-file-mode",
         "PATHS_ONLY",
+        "--target-hash-recursive=true",
         "--target-hash-modified-paths",
         "buck2/tests/targets/target_hashing/{}".format(src_changed),
     )
@@ -109,13 +111,17 @@ def grab(x: BuckResult) -> str:
 @buck_test(inplace=True)
 async def test_non_recursive_target_hash(buck: Buck) -> None:
     target = "fbcode//buck2/tests/targets/target_hashing:rule9"
-    pre_recursive = await buck.targets(target, "--show-target-hash", "--json")
+    pre_recursive = await buck.targets(
+        target, "--show-target-hash", "--json", "--target-hash-recursive=true"
+    )
     pre_direct = await buck.targets(
         target, "--show-target-hash", "--json", "--target-hash-recursive=false"
     )
 
     config = "-ctesting.hashing=1"
-    post_recursive = await buck.targets(target, config, "--show-target-hash", "--json")
+    post_recursive = await buck.targets(
+        target, config, "--show-target-hash", "--json", "--target-hash-recursive=true"
+    )
     post_direct = await buck.targets(
         target, config, "--show-target-hash", "--json", "--target-hash-recursive=false"
     )