Skip to content

Commit e615fea

Browse files
Nivaldo Bondançameta-codesync[bot]
authored andcommitted
Fix starlark lint errors in kotlin_library BUCK file
Summary: D93521644 introduced conditional target definitions using variables (`_uses_ksp_and_ap`, `_ksp_generates`, `_uses_ksp_and_kapt`) that are assigned but never used. The diff used `# buildifier: disable=unused-variable` comments to suppress buildifier warnings, but this doesn't work for Buck2's starlark linter which uses a different suppression format. The starlark linter has an `unused-assign` lint rule that flags these unused variable assignments. The correct suppression format is `# starlark-lint-disable unused-assign`. This fix adds `# starlark-lint-disable unused-assign` comments alongside the existing `# buildifier: disable=unused-variable` comments for the three affected variables: - `_uses_ksp_and_ap` - `_ksp_generates` - `_uses_ksp_and_kapt` Both comments are needed: - `# buildifier: disable=unused-variable` - suppresses buildifier warnings - `# starlark-lint-disable unused-assign` - suppresses Buck2 starlark linter warnings This resolves the `test_lint_buck2` test failure which runs `buck starlark lint buck2` and checks for lint errors in all Starlark files under the buck2 directory. [Session trajectory link](https://www.internalfb.com/intern/devai/devmate/inspector/?id=T256989125-22c236ee-ef70-4534-92f7-dde113fab2fb) Differential Revision: D94225083 fbshipit-source-id: 9b08f298d14806d0910ef37231d15dbf1538dad2
1 parent 9556d46 commit e615fea

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

prelude/python/make_py_package.bzl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,6 @@ def _make_py_package_wrapper(
425425
make_py_package_cmd,
426426
package_style,
427427
build_args,
428-
len(shared_libraries) > 0,
429428
preload_libraries,
430429
common_modules_args,
431430
dep_artifacts,
@@ -444,7 +443,6 @@ def _make_py_package_impl(
444443
make_py_package_cmd: RunInfo | None,
445444
package_style: PackageStyle,
446445
build_args: list[ArgLike],
447-
shared_libraries: bool,
448446
preload_libraries: cmd_args,
449447
common_modules_args: cmd_args,
450448
dep_artifacts: list[ArgLike],
@@ -512,7 +510,6 @@ def _make_py_package_impl(
512510
python_toolchain,
513511
main,
514512
output,
515-
shared_libraries,
516513
preload_libraries,
517514
symlink_tree_path,
518515
package_style,
@@ -833,7 +830,6 @@ def _pex_bootstrap_args(
833830
toolchain: PythonToolchainInfo,
834831
main: EntryPoint,
835832
output: Artifact,
836-
shared_libraries: bool,
837833
preload_libraries: cmd_args,
838834
symlink_tree_path: Artifact | None,
839835
package_style: PackageStyle,

0 commit comments

Comments
 (0)