Skip to content

Allow using LocalResourceInfo for RunInfo providers #841

Open
@thoughtpolice

Description

I have a test that runs QEMU, which needs the swtpm daemon that is needed to emulate TPMv2 functionality in software. I got LocalResourceInfo working for such a case, and it works pretty great. buck2 test path/to:test works correctly by starting the daemon and then running QEMU (there could be slightly better docs for this, but overall it wasn't too bad.)

But now I can't just buck2 run path/to:test anymore, because the resources (socket files) don't exist before starting QEMU. This is particularly annoying in my case, because I do in fact want to do buck2 run so that I can e.g. interactively debug inside QEMU.

I see no reason why RunInfo can't also work similarly to ExternalTestRunnerInfo, in that it should have two new fields, local_resources: list[label] and required_local_resources: [RequiredTestLocalResource], though in such a case that type should really be renamed RequiredLocalResource instead.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions