Skip to content

Commit d268a20

Browse files
authored
fix(core): bundler should not minimize static assets (#10658)
1 parent 0c791fb commit d268a20

File tree

7 files changed

+26
-1
lines changed

7 files changed

+26
-1
lines changed

.eslintignore

+1
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,4 @@ packages/create-docusaurus/lib/*
2121
packages/create-docusaurus/templates/facebook
2222

2323
website/_dogfooding/_swizzle_theme_tests
24+
website/_dogfooding/_asset-tests/badSyntax.js

.prettierignore

+2
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,5 @@ website/static/katex/katex.min.css
2929

3030
website/changelog
3131
website/_dogfooding/_swizzle_theme_tests
32+
website/_dogfooding/_asset-tests/badSyntax.js
33+
website/_dogfooding/_asset-tests/badSyntax.css

.stylelintignore

+1
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,6 @@ packages/docusaurus-*/lib/*
1313
packages/create-docusaurus/lib/*
1414
packages/create-docusaurus/templates/
1515
website/static/katex/katex.min.css
16+
website/_dogfooding/_asset-tests/badSyntax.css
1617

1718
jest/vendor

packages/docusaurus/src/webpack/plugins/StaticDirectoriesCopyPlugin.ts

+6
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,12 @@ export async function createStaticDirectoriesCopyPlugin({
5454
from: dir,
5555
to: outDir,
5656
toType: 'dir',
57+
info: {
58+
// Prevents Webpack from minimizing static files (js/css)
59+
// see https://github.com/facebook/docusaurus/pull/10658
60+
// see https://github.com/webpack-contrib/copy-webpack-plugin#skip-running-javascript-files-through-a-minimizer
61+
minimized: true,
62+
},
5763
})),
5864
});
5965
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
2+
3+
See https://github.com/facebook/docusaurus/issues/10460
4+
5+
Using bad JS syntax on purpose, this file shouldn't be processed and cause build errors, it should just be copied over.
6+
7+
import export with }{>< default switch
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
2+
Using bad JS syntax on purpose, this file shouldn't be processed and cause build errors, it should just be copied over.
3+
4+
import export with }{>< default switch
5+
6+
See https://github.com/facebook/docusaurus/issues/10460
7+
8+
See https://github.com/facebook/docusaurus/pull/10658

website/tsconfig.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,5 @@
3636
"skipLibCheck": false,
3737
"types": ["jest"]
3838
},
39-
"exclude": ["src/sw.js"]
39+
"exclude": ["build", ".docusaurus", "src/sw.js", "_dogfooding/_asset-tests"]
4040
}

0 commit comments

Comments
 (0)