fix(core): bundler should not minimize static assets (#10658)

slorber · web-flow · commit d268a20a6fdb · 2024-11-08T18:26:37.000+01:00
diff --git a/.eslintignore b/.eslintignore
@@ -21,3 +21,4 @@ packages/create-docusaurus/lib/*
 packages/create-docusaurus/templates/facebook
 
 website/_dogfooding/_swizzle_theme_tests
+website/_dogfooding/_asset-tests/badSyntax.js
diff --git a/.prettierignore b/.prettierignore
@@ -29,3 +29,5 @@ website/static/katex/katex.min.css
 
 website/changelog
 website/_dogfooding/_swizzle_theme_tests
+website/_dogfooding/_asset-tests/badSyntax.js
+website/_dogfooding/_asset-tests/badSyntax.css
diff --git a/.stylelintignore b/.stylelintignore
@@ -13,5 +13,6 @@ packages/docusaurus-*/lib/*
 packages/create-docusaurus/lib/*
 packages/create-docusaurus/templates/
 website/static/katex/katex.min.css
+website/_dogfooding/_asset-tests/badSyntax.css
 
 jest/vendor
diff --git a/packages/docusaurus/src/webpack/plugins/StaticDirectoriesCopyPlugin.ts b/packages/docusaurus/src/webpack/plugins/StaticDirectoriesCopyPlugin.ts
@@ -54,6 +54,12 @@ export async function createStaticDirectoriesCopyPlugin({
       from: dir,
       to: outDir,
       toType: 'dir',
+      info: {
+        // Prevents Webpack from minimizing static files (js/css)
+        // see https://github.com/facebook/docusaurus/pull/10658
+        // see https://github.com/webpack-contrib/copy-webpack-plugin#skip-running-javascript-files-through-a-minimizer
+        minimized: true,
+      },
     })),
   });
 }
diff --git a/website/_dogfooding/_asset-tests/badSyntax.css b/website/_dogfooding/_asset-tests/badSyntax.css
@@ -0,0 +1,7 @@
+
+
+See https://github.com/facebook/docusaurus/issues/10460
+
+Using bad JS syntax on purpose, this file shouldn't be processed and cause build errors, it should just be copied over.
+
+import export with }{>< default switch
diff --git a/website/_dogfooding/_asset-tests/badSyntax.js b/website/_dogfooding/_asset-tests/badSyntax.js
@@ -0,0 +1,8 @@
+
+Using bad JS syntax on purpose, this file shouldn't be processed and cause build errors, it should just be copied over.
+
+import export with }{>< default switch
+
+  See https://github.com/facebook/docusaurus/issues/10460
+
+    See https://github.com/facebook/docusaurus/pull/10658
diff --git a/website/tsconfig.json b/website/tsconfig.json
@@ -36,5 +36,5 @@
     "skipLibCheck": false,
     "types": ["jest"]
   },
-  "exclude": ["src/sw.js"]
+  "exclude": ["build", ".docusaurus", "src/sw.js", "_dogfooding/_asset-tests"]
 }

Original file line number	Diff line number	Diff line change
`@@ -21,3 +21,4 @@ packages/create-docusaurus/lib/*`
`21`	`21`	`packages/create-docusaurus/templates/facebook`
`22`	`22`
`23`	`23`	`website/_dogfooding/_swizzle_theme_tests`
	`24`	`+website/_dogfooding/_asset-tests/badSyntax.js`
Original file line number	Diff line number	Diff line change
`@@ -36,5 +36,5 @@`
`36`	`36`	`"skipLibCheck": false,`
`37`	`37`	`"types": ["jest"]`
`38`	`38`	`},`
`39`		`- "exclude": ["src/sw.js"]`
	`39`	`+ "exclude": ["build", ".docusaurus", "src/sw.js", "_dogfooding/_asset-tests"]`
`40`	`40`	`}`