Skip to content

Commit 272480d

Browse files
David Tolnayfacebook-github-bot
authored andcommitted
Update blake3 from 1.5.2 to 1.5.5
Summary: This updated was attempted in February in D68684463 and reverted in D69241207 due to duplicate symbol issues between these two archives: - third-party-buck/platform010/build/llvm-fb/15/__LLVMSupport__/__stripped__/lib/libLLVMSupport_pic.a - third-party/rust/__blake3-1.5.5-unix_x86_64__/libblake3-1.5.5-unix_x86_64.stripped.pic.a But I tested all the repro commands from the test plan of D69241207, and I tried other repro commands from the failed jobs linked under T214528654 such as https://www.internalfb.com/intern/test/844425077796846 (https://www.internalfb.com/intern/testinfra/diagnostics/17169973647165327.844425077796846.1739069000/), and none of them reproduce a duplicate symbol any more. So at least if this update gets reverted again, we will have new some new repro commands to work with. Reviewed By: diliop Differential Revision: D73682867 fbshipit-source-id: 906d9ff2dc289c6cc30285eabef4c85eb862da6b
1 parent 7eff594 commit 272480d

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ path = "tests/dotslash_tests.rs"
2020

2121
[dependencies]
2222
anyhow = "1.0.95"
23-
blake3 = { version = "=1.5.2", features = ["mmap", "rayon", "traits-preview"] }
23+
blake3 = { version = "=1.5.5", features = ["mmap", "rayon", "traits-preview"] }
2424
digest = "0.10"
2525
dirs = "6.0"
2626
dunce = "1.0.2"

0 commit comments

Comments
 (0)