Remove Client-Side Package Checksum

Summary: In this diff, we deprecate the client side Package Checksum being sent to Meta.

Reviewed By: KylinChang

Differential Revision: D70637187

fbshipit-source-id: 1b67aa28c42571e5a43038667fb99e2506f9e010

Author: maxalbrightmeta

facebook-core/src/main/java/com/facebook/appevents/AppEventsConstants.kt

@@ -210,9 +210,6 @@ object AppEventsConstants {
     /** Parameter key used to specify source application package. */
     const val EVENT_PARAM_SOURCE_APPLICATION = "fb_mobile_launch_source"
 
-    /** Parameter key used to specify package fingerprint. */
-    const val EVENT_PARAM_PACKAGE_FP = "fb_mobile_pckg_fp"
-
     // Parameter values
     /** Yes-valued parameter value to be used with parameter keys that need a Yes/No value */
     const val EVENT_PARAM_VALUE_YES = "1"

facebook-core/src/main/java/com/facebook/appevents/internal/SessionLogger.kt

@@ -11,19 +11,16 @@ package com.facebook.appevents.internal
 import android.content.Context
 import android.os.Bundle
 import android.text.format.DateUtils
-import com.facebook.FacebookSdk
 import com.facebook.LoggingBehavior
 import com.facebook.appevents.AppEventsConstants
 import com.facebook.appevents.AppEventsLogger
 import com.facebook.appevents.InternalAppEventsLogger
-import com.facebook.appevents.internal.HashUtils.computeChecksum
 import com.facebook.internal.Logger.Companion.log
 import com.facebook.internal.instrument.crashshield.AutoHandleExceptions
 import java.util.Locale
 
 @AutoHandleExceptions
 internal object SessionLogger {
-    private const val PACKAGE_CHECKSUM = "PCKGCHKSUM"
     private val TAG = SessionLogger::class.java.canonicalName
     private val INACTIVE_SECONDS_QUANTA =
         longArrayOf(
@@ -58,9 +55,6 @@ internal object SessionLogger {
         val sourAppInfoStr = sourceApplicationInfo?.toString() ?: "Unclassified"
         val eventParams = Bundle()
         eventParams.putString(AppEventsConstants.EVENT_PARAM_SOURCE_APPLICATION, sourAppInfoStr)
-        eventParams.putString(
-            AppEventsConstants.EVENT_PARAM_PACKAGE_FP, computePackageChecksum(context)
-        )
         val logger = InternalAppEventsLogger.createInstance(activityName, appId, null)
         logger.logEvent(AppEventsConstants.EVENT_NAME_ACTIVATED_APP, eventParams)
         if (InternalAppEventsLogger.getFlushBehavior() != AppEventsLogger.FlushBehavior.EXPLICIT_ONLY) {
@@ -124,37 +118,4 @@ internal object SessionLogger {
         }
         return quantaIndex
     }
-
-    private fun computePackageChecksum(context: Context): String? {
-        return try {
-            // First, try to check if package hash already computed
-            val pm = context.packageManager
-            val packageVersion = pm.getPackageInfo(context.packageName, 0).versionName
-            val packageHashSharedPrefKey = PACKAGE_CHECKSUM + ";" + packageVersion
-            val preferences =
-                context.getSharedPreferences(
-                    FacebookSdk.APP_EVENT_PREFERENCES,
-                    Context.MODE_PRIVATE
-                )
-            var packageHash = preferences.getString(packageHashSharedPrefKey, null)
-            if (packageHash != null && packageHash.length == 32) {
-                return packageHash
-            }
-            // Second, try to get the checksum through Android S checksum API
-            val androidPackageManagerChecksum =
-                HashUtils.computeChecksumWithPackageManager(context, null)
-            packageHash =
-                if (androidPackageManagerChecksum != null) {
-                    androidPackageManagerChecksum
-                } else {
-                    // Finally, compute checksum and cache it.
-                    val ai = pm.getApplicationInfo(context.packageName, 0)
-                    computeChecksum(ai.sourceDir)
-                }
-            preferences.edit().putString(packageHashSharedPrefKey, packageHash).apply()
-            packageHash
-        } catch (e: Exception) {
-            null
-        }
-    }
 }

facebook-core/src/test/kotlin/com/facebook/appevents/internal/SessionLoggerTest.kt

@@ -176,18 +176,4 @@ class SessionLoggerTest : FacebookPowerMockTestCase() {
         )
             .isEqualTo(fbMobileTimeBetweenSessions)
     }
-
-    @Test
-    fun `test logActivateApp will log EVENT_NAME_ACTIVATED_APP event and package checksum`() {
-        SessionLogger.logActivateApp(activityName, null, appId, mockContext)
-
-        verify(mockInternalAppEventsLogger)
-            .logEvent(
-                eq(AppEventsConstants.EVENT_NAME_ACTIVATED_APP),
-                bundleArgumentCaptor.capture()
-            )
-        val capturedBundle = bundleArgumentCaptor.firstValue
-        assertThat(capturedBundle.getString(AppEventsConstants.EVENT_PARAM_PACKAGE_FP))
-            .isEqualTo(mockChecksum)
-    }
 }