`com.android.installreferrer` is called in the main thread which leads to ANR

[ddovod]

Checklist before submitting a bug report

• I've updated to the latest released version of the SDK
• I've searched for existing Github issues
• I've looked for existing answers on Stack Overflow, the Facebook Developer Community Forum and the Facebook Developers Group
• I've read the Code of Conduct
• This issue is not security related and can safely be disclosed publicly on GitHub

Java version

8

Android version

api 23+

Android SDK version

12.1

Installation platform & version

Gradle

Package

Other / I don't know

Goals

According to our investigations com.android.installreferrer can block the callers thread for a long time which in case of main thread leads to ANR. We call com.android.installreferrer from the background thread, it is safer and works just fine. Looks like fb sdk calls it from the main thread and we have a bunch of ANR reports that shows this case. Please consider moving com.android.installreferrer to the background thread. Thanks

Expected results

com.android.installreferrer is used in the background thread, no ANRs

Actual results

com.android.installreferrer is used in the main thread, ANRs

Steps to reproduce

No response

Code samples & details

Thread state: BLOCKED
android.os.BinderProxy.transactNative(BinderProxy.java:N)
android.os.BinderProxy.transact(BinderProxy.java:N)
e.c.a.a.a.XN(BaseProxy.java:N)
e.c.a.b.a.a$a$a.e(IGetInstallReferrerService.java:N)
com.android.installreferrer.api.InstallReferrerClientImpl.getInstallReferrer(InstallReferrerClientImpl.java:N)
com.facebook.internal.v$b.onInstallReferrerSetupFinished(InstallReferrerUtil.kt:N)
com.android.installreferrer.api.InstallReferrerClientImpl$InstallReferrerServiceConnection.onServiceConnected(InstallReferrerClientImpl.java:N)
android.app.LoadedApk$ServiceDispatcher.doConnected(LoadedApk.java:N)
android.app.LoadedApk$ServiceDispatcher$RunConnection.run(LoadedApk.java:N)
android.os.Handler.handleCallback(Handler.java:N)
android.os.Handler.dispatchMessage(Handler.java:N)
android.os.Looper.loop(Looper.java:N)
android.app.ActivityThread.main(ActivityThread.java:N)
java.lang.reflect.Method.invoke(Method.java:N)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:N)
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:N)

Edit: added a stacktrace

[Gell6]

Can you give me script attack for apk???

[KulArtsiom]

Hi guys!
I think ANR occur because you don't call the endConnection() on your InstallReferrerClient instance in tryConnectReferrerInfo function.

Information about it you can find in officially documentation

[MrAugMyo]

https://www.facebook.com/profile.php?id=100016695042794

[Lok1n8]

same issue

[jasoncfpl]

same issue

[OldSlash]

Issue is not fixed, we observe exact the same issue on FBSDK 16.0.1

[EllieTellie]

@KylinChang

29af39e This commit most likely does not fix this issue as it is simply closing it but other parts of the system can still be slow on the binder call.

The issue is triggered by the call: referrerClient.installReferrer on line 41 in https://github.com/facebook/facebook-android-sdk/blob/main/facebook-core/src/main/java/com/facebook/internal/InstallReferrerUtil.kt

If you look at the source, it's a bit tricky to follow because it is obfuscated, for InstallReferrerClientImpl you will find it does the following:
this(((InstallReferrerClientImpl)super).service.c(bundle));
This then calls Transact on the IBinder which causes the ANR.

From the ANR dashboard:
The latency of a Binder call is hard to predict. It can be affected not only by the complexity of the call itself, but also by intermittent factors such as system server lock contention. You should treat them as you would treat I/O calls, and avoid, if possible, making Binder calls in the main thread. If making a Binder call from the main thread is unavoidable, make sure to instrument and monitor such calls to detect slowness.

So this ends up being called on the main thread because onInstallReferrerSetupFinished callback happens on the main thread.

I'm not an Android or Kotlin developer so unfortunately I have no easy fixes here, but this referrerClient.installReferrer call should probably be async.

[burak-cypher]

Any updates on this? Getting exactly the same ANR on Play Console, not so rare. Using Unity SDK 15.1.0.

[rampr]

Having the same issue. Any updates here ?

[umeriqbalbutt]

Having the same issue any update on this ?

[AshikRaj]

We're on 16.2.0 and we're still seeing the same issue. Is there an update on when this will be fixed?