Fix performance issue: Cache background sync job queries and skip on frontend

Author: David Evbodaghe

includes/Framework/Utilities/BackgroundJobHandler.php

@@ -229,6 +229,8 @@ protected function is_queue_empty() {
 	protected function invalidate_queue_cache() {
 		delete_transient( $this->queue_empty_cache_key );
 		delete_transient( $this->sync_in_progress_cache_key );
+		// Also clear the is_sync_in_progress cache used by Sync class
+		delete_transient( 'wc_facebook_sync_in_progress' );
 	}
 
 
@@ -543,9 +545,8 @@ public function get_jobs( $args = [] ) {
 		$args = wp_parse_args(
 			$args,
 			[
-				'order'     => 'DESC',
-				'orderby'   => 'option_id',
-				'use_cache' => true,
+				'order'   => 'DESC',
+				'orderby' => 'option_id',
 			]
 		);
 
@@ -554,19 +555,6 @@ public function get_jobs( $args = [] ) {
 			return null; // Return no jobs on frontend to avoid query
 		}
 
-		// For status=processing queries, use cache to avoid expensive queries
-		$cache_key = null;
-		if ( $args['use_cache'] && ! empty( $args['status'] ) ) {
-			$statuses = (array) $args['status'];
-			if ( count( $statuses ) === 1 && 'processing' === $statuses[0] ) {
-				$cache_key = $this->sync_in_progress_cache_key;
-				$cached    = get_transient( $cache_key );
-				if ( false !== $cached ) {
-					return 'has_jobs' === $cached ? [ (object) [ 'cached' => true ] ] : null;
-				}
-			}
-		}
-
 		$replacements = [ $this->identifier . '_job_%' ];
 		$status_query = '';
 
@@ -596,10 +584,6 @@ public function get_jobs( $args = [] ) {
 		$results = $wpdb->get_col( $query );
 
 		if ( empty( $results ) ) {
-			// Cache the empty result for processing status queries - invalidated when job status changes
-			if ( $cache_key ) {
-				set_transient( $cache_key, 'no_jobs', 0 );
-			}
 			return null;
 		}
 
@@ -614,11 +598,6 @@ public function get_jobs( $args = [] ) {
 			$jobs[] = $job;
 		}
 
-		// Cache the result for processing status queries - invalidated when job status changes
-		if ( $cache_key ) {
-			set_transient( $cache_key, 'has_jobs', 0 );
-		}
-
 		return $jobs;
 	}
 

includes/Products/Sync.php

@@ -263,12 +263,30 @@ private function get_product_index( $product_id ) {
 	 * @return bool
 	 */
 	public static function is_sync_in_progress() {
+		// On frontend, skip the check entirely - visitors don't need sync status
+		if ( ! is_admin() && ! wp_doing_ajax() && ! wp_doing_cron() ) {
+			return false;
+		}
+
+		// Check cache first
+		$cache_key = 'wc_facebook_sync_in_progress';
+		$cached    = get_transient( $cache_key );
+		if ( false !== $cached ) {
+			return 'yes' === $cached;
+		}
+
+		// Query for processing jobs
 		$jobs = facebook_for_woocommerce()->get_products_sync_background_handler()->get_jobs(
 			array(
 				'status' => 'processing',
 			)
 		);
 
-		return ! empty( $jobs );
+		$in_progress = ! empty( $jobs );
+
+		// Cache the result - invalidated when job status changes
+		set_transient( $cache_key, $in_progress ? 'yes' : 'no', 0 );
+
+		return $in_progress;
 	}
 }

includes/Utilities/DebugTools.php

@@ -71,9 +71,10 @@ public function clean_up_old_background_sync_options() {
 		// Delete job entries (but not cache transients which use different pattern)
 		$wpdb->query( "DELETE FROM {$wpdb->options} WHERE option_name LIKE 'wc_facebook_background_product_sync_job_%'" );
 
-		// Invalidate the queue cache since we deleted jobs directly from the database
+		// Invalidate all sync-related caches since we deleted jobs directly from the database
 		delete_transient( 'wc_facebook_background_product_sync_queue_empty' );
 		delete_transient( 'wc_facebook_background_product_sync_sync_in_progress' );
+		delete_transient( 'wc_facebook_sync_in_progress' );
 
 		return __( 'Background sync jobs have been deleted.', 'facebook-for-woocommerce' );
 	}