Release of v2.11.3 that includes the following bug fixes:

- Handle errors from batch API
- Handle network errors, e.g. timeout, destination unreachable

Author: supasate

CONTRIBUTING.md

@@ -2,10 +2,6 @@
 We want to make contributing to this project as easy and transparent as
 possible.
 
-## Code of Conduct
-
-The code of conduct is described in [`CODE_OF_CONDUCT.md`](CODE_OF_CONDUCT.md)
-
 ## Our Development Process
 The Facebook Ads API SDK for NodeJS is currently developed in Facebook's internal
 repositories and then exported out to GitHub by a Facebook team member. We invite

bower.json

@@ -1,9 +1,9 @@
 {
   "name": "facebook-ads-sdk",
-  "version": "2.11.1",
+  "version": "2.11.3",
   "description": "SDK for the Facebook Ads API in Javascript and Node.js",
   "authors": [
-    "Zain Aziz<[email protected]>",
+    "Zain Aziz <[email protected]>",
     "Neil Chen <[email protected]>",
     "Cloud Xu <[email protected]>",
     "Supasate Choochaisri <[email protected]>"

gulpfile.js

@@ -31,6 +31,11 @@ function roll (format, entry, name, entry_dir, dest_dir) {
     format: format,
     exports: 'named',
     moduleName: 'fb',
+    external: ['fs', 'path'],
+    globals: {
+      'fs': 'fs',
+      'path': 'path',
+    },
     plugins: [
       babel(babelrc.default({
         config: {

package.json

@@ -1,14 +1,14 @@
 {
   "name": "facebook-nodejs-ads-sdk",
-  "version": "2.11.1",
+  "version": "2.11.3",
   "description": "SDK for the Facebook Ads API in Javascript and Node.js",
   "author": "Facebook",
   "maintainers": [
     "Zain Aziz <[email protected]>, Neil Chen <[email protected]>, Cloud Xu <[email protected]>, Supasate Choochaisri <[email protected]>, lucascosta <[email protected]>"
   ],
-  "homepage": "https://github.com/facebook/facebook-js-ads-sdk",
+  "homepage": "https://github.com/facebook/facebook-nodejs-ads-sdk",
   "bugs": {
-    "url": "https://github.com/facebook/facebook-js-ads-sdk/issues"
+    "url": "https://github.com/facebook/facebook-nodejs-ads-sdk/issues"
   },
   "keywords": [
     "facebook",
@@ -27,7 +27,7 @@
   ],
   "repository": {
     "type": "git",
-    "url": "git://github.com/facebook/facebook-js-ads-sdk.git"
+    "url": "git://github.com/facebook/facebook-nodejs-ads-sdk.git"
   },
   "devDependencies": {
     "babel-cli": "^6.24.1",

src/api-response.js

@@ -11,8 +11,8 @@
 import HTTP_STATUS from './http-status';
 import {FacebookRequestError} from './exceptions';
 /**
-  * Encapsulates an http response from Facebook's Graph API.
-  */
+ * Encapsulates an http response from Facebook's Graph API.
+ */
 class APIResponse {
   _body: string;
   _httpStatus: string;

src/exceptions.js

@@ -5,6 +5,10 @@
  * This source code is licensed under the license found in the
  * LICENSE file in the root directory of this source tree.
  */
+// request-promise error types
+const REQUEST_ERROR = 'RequestError';
+const STATUS_CODE_ERROR = 'StatusCodeError';
+
 function FacebookError (error) {
   this.name = 'FacebookError';
   this.message = error.message;
@@ -24,17 +28,63 @@ export class FacebookRequestError extends FacebookError {
    * @param  {Object}   data
    */
   constructor (response, method, url, data) {
-    let error = response.body.error;
-    let message = error.error_user_msg
-      ? `${error.error_user_title}: ${error.error_user_msg}`
-      : error.message;
-    super(message);
+    const errorResponse = constructErrorResponse(response);
+
+    super(errorResponse);
     this.name = 'FacebookRequestError';
-    this.message = message;
-    this.status = response.status;
-    this.response = response.body;
+    this.message = errorResponse.message;
+    this.status = errorResponse.status;
+    this.response = errorResponse.body;
     this.method = method;
     this.url = url;
-    if (data) this.data = data;
+    if (data) {
+      this.data = data;
+    }
+  }
+}
+
+/**
+ * Error response has several structures depended on called APIs or errors.
+ * This method contructs and formats the response into the same structure for
+ * creating a FacebookRequestError object.
+ */
+function constructErrorResponse (response: Object) {
+  let body;
+  let message;
+  let status;
+
+  // Batch request error contains code and body fields
+  const isBatchResponse = response.code && response.body;
+
+  if (isBatchResponse) {
+    // Handle batch response
+    body = typeof response.body === 'string'
+      ? JSON.parse(response.body)
+      : response.body;
+    status = response.code;
+    message = body.error.message;
+  } else {
+    // Handle single response
+    if (response.name === STATUS_CODE_ERROR) {
+      // Handle when we can get response error code
+      body = response.error ? response.error : response;
+      body = typeof body === 'string'
+        ? JSON.parse(body)
+        : body;
+      // Construct an error message from subfields in body.error
+      message = body.error.error_user_msg
+        ? `${body.error.error_user_title}: ${body.error.error_user_msg}`
+        : body.error.message;
+      status = response.statusCode;
+    } else if (response.name === REQUEST_ERROR) {
+      // Handle network errors e.g. timeout, destination unreachable
+      body = {error: response.error};
+      // An error message is in the response already
+      message = response.message;
+      // Network errors have no status code
+      status = null;
+    }
   }
+
+  return {body, message, status};
 }

src/http.js

@@ -119,10 +119,6 @@ export default class Http {
     }
 
     return requestPromise(options).catch((response: Object) => {
-      response = {
-        body: response.error ? response.error : response,
-        status: response.statusCode
-      };
       throw response;
     });
   }