Skip to content

Commit

Permalink
exlcude TTL1 trap when set up TTL zero for trap loop
Browse files Browse the repository at this point in the history
Summary:
Currently AgentVoqSwitchLineRateTest.dramBlocked is failing during warmboot because both TTL_0 and TTL_1 trap are programmed. They correspond to the same underlying sai object programming the same rx reason https://fburl.com/code/nsewyupj, which could lead to conflict or confusion during warmboot when agent attempt to load sai objects and restore switch state.

This diff resolves this issue by excluding TTL1 trap when calling setTTLZeroCpuConfig()

Reviewed By: jasmeetbagga

Differential Revision:
D68798218

Privacy Context Container: L1125642

fbshipit-source-id: 557310efc9d7bee273f4ad7b2cb78e4c426a2251
  • Loading branch information
daiwei1983 authored and facebook-github-bot committed Jan 30, 2025
1 parent 445cf26 commit 50b2a72
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fboss/agent/test/utils/CoppTestUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ void setTTLZeroCpuConfig(
// don't configure if not supported
return;
}

excludeTTL1TrapConfig(config);
std::vector<cfg::PacketRxReasonToQueue> rxReasons;
bool addTtlRxReason = true;
if (config.cpuTrafficPolicy().has_value() &&
Expand Down

0 comments on commit 50b2a72

Please sign in to comment.