Skip to content

Commit 9858da9

Browse files
jasmeetbaggameta-codesync[bot]
authored andcommitted
Add next-hop-group-member hardware object selector
Summary: Add `HwObjectType::NEXT_HOP_GROUP_MEMBER` and map it to `SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER`, allowing `fboss2 show hw-object` to retrieve next-hop-group-member objects independently. Add CLI argument parsing coverage for the new enum value. landed-with-radar-review Reviewed By: shri-khare Differential Revision: D116091695 fbshipit-source-id: 166d20f2cf9cd6aa1498a8a84f3720336b49b7c9
1 parent 5cdae17 commit 9858da9

3 files changed

Lines changed: 8 additions & 0 deletions

File tree

fboss/agent/hw/sai/switch/SaiSwitch.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5125,6 +5125,9 @@ std::string SaiSwitch::listObjects(
51255125
objTypes.push_back(SAI_OBJECT_TYPE_NEXT_HOP_GROUP);
51265126
objTypes.push_back(SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER);
51275127
break;
5128+
case HwObjectType::NEXT_HOP_GROUP_MEMBER:
5129+
objTypes.push_back(SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER);
5130+
break;
51285131
case HwObjectType::ROUTER_INTERFACE:
51295132
objTypes.push_back(SAI_OBJECT_TYPE_ROUTER_INTERFACE);
51305133
break;

fboss/agent/if/ctrl.thrift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -768,6 +768,7 @@ enum HwObjectType {
768768
SYSTEM_PORT = 25,
769769
FIRMWARE = 26,
770770
SRV6 = 27,
771+
NEXT_HOP_GROUP_MEMBER = 28,
771772
}
772773

773774
exception FbossFibUpdateError {

fboss/cli/fboss2/test/CmdArgsTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,10 @@ TEST(CmdArgsTest, HwObjectList) {
136136
ASSERT_NO_THROW(utils::HwObjectList({"PORT"}));
137137
EXPECT_THAT(
138138
utils::HwObjectList({"PORT"}).data(), ElementsAre(HwObjectType::PORT));
139+
ASSERT_NO_THROW(utils::HwObjectList({"NEXT_HOP_GROUP_MEMBER"}));
140+
EXPECT_THAT(
141+
utils::HwObjectList({"NEXT_HOP_GROUP_MEMBER"}).data(),
142+
ElementsAre(HwObjectType::NEXT_HOP_GROUP_MEMBER));
139143
ASSERT_NO_THROW(utils::HwObjectList({"LAG", "MIRROR"}));
140144
EXPECT_THAT(
141145
utils::HwObjectList({"LAG", "MIRROR"}).data(),

0 commit comments

Comments
 (0)