Skip to content

Commit b878d4a

Browse files
Parvez Shaikhfacebook-github-bot
Parvez Shaikh
authored andcommitted
do not enable source ip qualifier for chenab in counter tests
Summary: source ip qualifier is unavailable for chenab as of now. Reviewed By: jasmeetbagga Differential Revision: D68792484 fbshipit-source-id: 4616aacec8ecd3ba44bdec204926c9fe00d0cfac
1 parent 0e4f512 commit b878d4a

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

fboss/agent/test/agent_hw_tests/AgentHwAclQualifierTest.cpp

+17-4
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,15 @@ void configureAllIpQualifiers(
3535
cfg::AsicType asicType) {
3636
cfg::Ttl ttl;
3737
std::tie(*ttl.value(), *ttl.mask()) = std::make_tuple(0x80, 0x80);
38+
bool enableSrcIpQualifier =
39+
(asicType != cfg::AsicType::ASIC_TYPE_CHENAB) && enable;
3840

3941
if (asicType != cfg::AsicType::ASIC_TYPE_JERICHO3) {
4042
// TODO(daiweix): remove after J3 ACL supports IP_TYPE
4143
configureQualifier(acl->ipType(), enable, ipType);
4244
}
4345
if (ipType == cfg::IpType::IP6) {
44-
configureQualifier(acl->srcIp(), enable, "::ffff:c0a8:1");
46+
configureQualifier(acl->srcIp(), enableSrcIpQualifier, "::ffff:c0a8:1");
4547
configureQualifier(
4648
acl->dstIp(), enable, "2401:db00:3020:70e2:face:0:63:0/64");
4749

@@ -55,7 +57,7 @@ void configureAllIpQualifiers(
5557
cfg::AclLookupClass::DST_CLASS_L3_LOCAL_2);
5658

5759
} else {
58-
configureQualifier(acl->srcIp(), enable, "192.168.0.1");
60+
configureQualifier(acl->srcIp(), enableSrcIpQualifier, "192.168.0.1");
5961
configureQualifier(acl->dstIp(), enable, "192.168.0.0/24");
6062

6163
configureQualifier(
@@ -165,37 +167,48 @@ class AgentHwAclQualifierTest : public AgentHwTest {
165167
cfg::AclEntry* acl,
166168
SwitchID switchID = SwitchID(0)) {
167169
auto asicType = getAsicType(switchID);
170+
bool enableSrcIpQualifier = (asicType != cfg::AsicType::ASIC_TYPE_CHENAB);
171+
bool enableEtherTypeQualifier =
172+
(asicType == cfg::AsicType::ASIC_TYPE_CHENAB);
168173
cfg::Ttl ttl;
169174
std::tie(*ttl.value(), *ttl.mask()) = std::make_tuple(0x80, 0x80);
170175

171176
if (asicType != cfg::AsicType::ASIC_TYPE_JERICHO3) {
172177
// TODO(daiweix): remove after J3 ACL supports IP_TYPE
173178
configureQualifier(acl->ipType(), true, cfg::IpType::IP4);
174179
}
175-
configureQualifier(acl->srcIp(), true, "192.168.0.1");
180+
configureQualifier(acl->srcIp(), enableSrcIpQualifier, "192.168.0.1");
176181
configureQualifier(acl->dstIp(), true, "192.168.0.0/24");
177182
configureQualifier(acl->dscp(), true, 0x24);
178183
configureQualifier(acl->ttl(), true, ttl);
179184
configureQualifier(acl->proto(), true, 6);
185+
configureQualifier(
186+
acl->etherType(), enableEtherTypeQualifier, cfg::EtherType::IPv4);
180187
}
181188

182189
void configureIp6QualifiersHelper(
183190
cfg::AclEntry* acl,
184191
SwitchID switchID = SwitchID(0)) {
185192
auto asicType = getAsicType(switchID);
193+
auto enableSrcIpQualifier = (asicType != cfg::AsicType::ASIC_TYPE_CHENAB);
194+
bool enableEtherTypeQualifier =
195+
(asicType == cfg::AsicType::ASIC_TYPE_CHENAB);
186196
cfg::Ttl ttl;
187197
std::tie(*ttl.value(), *ttl.mask()) = std::make_tuple(0x80, 0x80);
188198

189199
if (asicType != cfg::AsicType::ASIC_TYPE_JERICHO3) {
190200
// TODO(daiweix): remove after J3 ACL supports IP_TYPE
191201
configureQualifier(acl->ipType(), true, cfg::IpType::IP6);
192202
}
193-
configureQualifier(acl->srcIp(), true, "::ffff:c0a8:1");
203+
204+
configureQualifier(acl->srcIp(), enableSrcIpQualifier, "::ffff:c0a8:1");
194205
configureQualifier(
195206
acl->dstIp(), true, "2401:db00:3020:70e2:face:0:63:0/64");
196207
configureQualifier(acl->dscp(), true, 0x24);
197208
configureQualifier(acl->ttl(), true, ttl);
198209
configureQualifier(acl->proto(), true, 6);
210+
configureQualifier(
211+
acl->etherType(), enableEtherTypeQualifier, cfg::EtherType::IPv6);
199212
}
200213

201214
std::string kAclName() const {

0 commit comments

Comments
 (0)