Skip to content

Commit 003bdb6

Browse files
thedavekwonfacebook-github-bot
thedavekwon
authored and
facebook-github-bot
committed
Add deprecated_terse_writes with custom default fixtures
Summary: add fixtures Reviewed By: iahs Differential Revision: D68844175 fbshipit-source-id: 75863bbb04300213b53e385ddab8f96e26ef0daf
1 parent 445c8ea commit 003bdb6

13 files changed

+4187
-4
lines changed

‎thrift/compiler/test/fixtures/terse_write/out/cpp2_deprecated_terse_writ/gen-cpp2/deprecated_terse_write_constants.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ namespace facebook::thrift::test::terse_write::deprecated {
1414
namespace deprecated_terse_write_constants {
1515

1616

17-
::std::string_view _fbthrift_schema_a4403c601bb38b4b() {
17+
::std::string_view _fbthrift_schema_fdf9c457eda6d727() {
1818
return "";
1919
}
20-
::folly::Range<const ::std::string_view*> _fbthrift_schema_a4403c601bb38b4b_includes() {
20+
::folly::Range<const ::std::string_view*> _fbthrift_schema_fdf9c457eda6d727_includes() {
2121
return {};
2222
}
2323

‎thrift/compiler/test/fixtures/terse_write/out/cpp2_deprecated_terse_writ/gen-cpp2/deprecated_terse_write_constants.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ namespace facebook::thrift::test::terse_write::deprecated {
1414
/** Glean {"file": "thrift/compiler/test/fixtures/terse_write/src/deprecated_terse_write.thrift"} */
1515
namespace deprecated_terse_write_constants {
1616

17-
FOLLY_EXPORT ::std::string_view _fbthrift_schema_a4403c601bb38b4b();
18-
FOLLY_EXPORT ::folly::Range<const ::std::string_view*> _fbthrift_schema_a4403c601bb38b4b_includes();
17+
FOLLY_EXPORT ::std::string_view _fbthrift_schema_fdf9c457eda6d727();
18+
FOLLY_EXPORT ::folly::Range<const ::std::string_view*> _fbthrift_schema_fdf9c457eda6d727_includes();
1919

2020
} // namespace deprecated_terse_write_constants
2121
} // namespace facebook::thrift::test::terse_write::deprecated

‎thrift/compiler/test/fixtures/terse_write/out/cpp2_deprecated_terse_writ/gen-cpp2/deprecated_terse_write_data.cpp

+154
Original file line numberDiff line numberDiff line change
@@ -328,5 +328,159 @@ THRIFT_DATA_MEMBER const std::array<int, 2> TStructDataStorage<::facebook::thrif
328328
-1,
329329
}};
330330

331+
THRIFT_DATA_MEMBER const std::string_view TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault>::name = "DeprecatedTerseWriteWithCustomDefault";
332+
THRIFT_DATA_MEMBER const std::array<std::string_view, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault>::fields_names = { {
333+
"bool_field"sv,
334+
"byte_field"sv,
335+
"short_field"sv,
336+
"int_field"sv,
337+
"long_field"sv,
338+
"float_field"sv,
339+
"double_field"sv,
340+
"string_field"sv,
341+
"binary_field"sv,
342+
"enum_field"sv,
343+
"list_field"sv,
344+
"set_field"sv,
345+
"map_field"sv,
346+
}};
347+
THRIFT_DATA_MEMBER const std::array<int16_t, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault>::fields_ids = { {
348+
1,
349+
2,
350+
3,
351+
4,
352+
5,
353+
6,
354+
7,
355+
8,
356+
9,
357+
10,
358+
11,
359+
12,
360+
13,
361+
}};
362+
THRIFT_DATA_MEMBER const std::array<protocol::TType, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault>::fields_types = { {
363+
TType::T_BOOL,
364+
TType::T_BYTE,
365+
TType::T_I16,
366+
TType::T_I32,
367+
TType::T_I64,
368+
TType::T_FLOAT,
369+
TType::T_DOUBLE,
370+
TType::T_STRING,
371+
TType::T_STRING,
372+
TType::T_I32,
373+
TType::T_LIST,
374+
TType::T_SET,
375+
TType::T_MAP,
376+
}};
377+
THRIFT_DATA_MEMBER const std::array<std::string_view, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault>::storage_names = { {
378+
"__fbthrift_field_bool_field"sv,
379+
"__fbthrift_field_byte_field"sv,
380+
"__fbthrift_field_short_field"sv,
381+
"__fbthrift_field_int_field"sv,
382+
"__fbthrift_field_long_field"sv,
383+
"__fbthrift_field_float_field"sv,
384+
"__fbthrift_field_double_field"sv,
385+
"__fbthrift_field_string_field"sv,
386+
"__fbthrift_field_binary_field"sv,
387+
"__fbthrift_field_enum_field"sv,
388+
"__fbthrift_field_list_field"sv,
389+
"__fbthrift_field_set_field"sv,
390+
"__fbthrift_field_map_field"sv,
391+
}};
392+
THRIFT_DATA_MEMBER const std::array<int, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault>::isset_indexes = { {
393+
0,
394+
1,
395+
2,
396+
3,
397+
4,
398+
5,
399+
6,
400+
7,
401+
8,
402+
9,
403+
10,
404+
11,
405+
12,
406+
}};
407+
408+
THRIFT_DATA_MEMBER const std::string_view TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault>::name = "DeprecatedTerseWriteWithRedundantCustomDefault";
409+
THRIFT_DATA_MEMBER const std::array<std::string_view, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault>::fields_names = { {
410+
"bool_field"sv,
411+
"byte_field"sv,
412+
"short_field"sv,
413+
"int_field"sv,
414+
"long_field"sv,
415+
"float_field"sv,
416+
"double_field"sv,
417+
"string_field"sv,
418+
"binary_field"sv,
419+
"enum_field"sv,
420+
"list_field"sv,
421+
"set_field"sv,
422+
"map_field"sv,
423+
}};
424+
THRIFT_DATA_MEMBER const std::array<int16_t, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault>::fields_ids = { {
425+
1,
426+
2,
427+
3,
428+
4,
429+
5,
430+
6,
431+
7,
432+
8,
433+
9,
434+
10,
435+
11,
436+
12,
437+
13,
438+
}};
439+
THRIFT_DATA_MEMBER const std::array<protocol::TType, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault>::fields_types = { {
440+
TType::T_BOOL,
441+
TType::T_BYTE,
442+
TType::T_I16,
443+
TType::T_I32,
444+
TType::T_I64,
445+
TType::T_FLOAT,
446+
TType::T_DOUBLE,
447+
TType::T_STRING,
448+
TType::T_STRING,
449+
TType::T_I32,
450+
TType::T_LIST,
451+
TType::T_SET,
452+
TType::T_MAP,
453+
}};
454+
THRIFT_DATA_MEMBER const std::array<std::string_view, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault>::storage_names = { {
455+
"__fbthrift_field_bool_field"sv,
456+
"__fbthrift_field_byte_field"sv,
457+
"__fbthrift_field_short_field"sv,
458+
"__fbthrift_field_int_field"sv,
459+
"__fbthrift_field_long_field"sv,
460+
"__fbthrift_field_float_field"sv,
461+
"__fbthrift_field_double_field"sv,
462+
"__fbthrift_field_string_field"sv,
463+
"__fbthrift_field_binary_field"sv,
464+
"__fbthrift_field_enum_field"sv,
465+
"__fbthrift_field_list_field"sv,
466+
"__fbthrift_field_set_field"sv,
467+
"__fbthrift_field_map_field"sv,
468+
}};
469+
THRIFT_DATA_MEMBER const std::array<int, 13> TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault>::isset_indexes = { {
470+
0,
471+
1,
472+
2,
473+
3,
474+
4,
475+
5,
476+
6,
477+
7,
478+
8,
479+
9,
480+
10,
481+
11,
482+
12,
483+
}};
484+
331485
} // namespace thrift
332486
} // namespace apache

‎thrift/compiler/test/fixtures/terse_write/out/cpp2_deprecated_terse_writ/gen-cpp2/deprecated_terse_write_data.h

+32
Original file line numberDiff line numberDiff line change
@@ -114,4 +114,36 @@ template <> struct TStructDataStorage<::facebook::thrift::test::terse_write::dep
114114
static const std::array<int, fields_size> isset_indexes;
115115
};
116116

117+
template <> struct TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault> {
118+
static constexpr const std::size_t fields_size = 13;
119+
static const std::string_view name;
120+
static const std::array<std::string_view, fields_size> fields_names;
121+
static const std::array<int16_t, fields_size> fields_ids;
122+
static const std::array<protocol::TType, fields_size> fields_types;
123+
124+
private:
125+
// The following fields describe internal storage metadata, and are private to
126+
// prevent user logic from accessing them, but they can be inspected by
127+
// debuggers.
128+
static const std::array<std::string_view, fields_size> storage_names;
129+
// -1 if the field has no isset.
130+
static const std::array<int, fields_size> isset_indexes;
131+
};
132+
133+
template <> struct TStructDataStorage<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault> {
134+
static constexpr const std::size_t fields_size = 13;
135+
static const std::string_view name;
136+
static const std::array<std::string_view, fields_size> fields_names;
137+
static const std::array<int16_t, fields_size> fields_ids;
138+
static const std::array<protocol::TType, fields_size> fields_types;
139+
140+
private:
141+
// The following fields describe internal storage metadata, and are private to
142+
// prevent user logic from accessing them, but they can be inspected by
143+
// debuggers.
144+
static const std::array<std::string_view, fields_size> storage_names;
145+
// -1 if the field has no isset.
146+
static const std::array<int, fields_size> isset_indexes;
147+
};
148+
117149
}} // apache::thrift

‎thrift/compiler/test/fixtures/terse_write/out/cpp2_deprecated_terse_writ/gen-cpp2/deprecated_terse_write_for_each_field.h

+40
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,46 @@ struct ForEachField<::facebook::thrift::test::terse_write::deprecated::CppRefStr
9494
f(1, static_cast<T&&>(t).struct_ref_field_ref()...);
9595
}
9696
};
97+
98+
template <>
99+
struct ForEachField<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault> {
100+
template <typename F, typename... T>
101+
void operator()([[maybe_unused]] F&& f, [[maybe_unused]] T&&... t) const {
102+
f(0, static_cast<T&&>(t).bool_field_ref()...);
103+
f(1, static_cast<T&&>(t).byte_field_ref()...);
104+
f(2, static_cast<T&&>(t).short_field_ref()...);
105+
f(3, static_cast<T&&>(t).int_field_ref()...);
106+
f(4, static_cast<T&&>(t).long_field_ref()...);
107+
f(5, static_cast<T&&>(t).float_field_ref()...);
108+
f(6, static_cast<T&&>(t).double_field_ref()...);
109+
f(7, static_cast<T&&>(t).string_field_ref()...);
110+
f(8, static_cast<T&&>(t).binary_field_ref()...);
111+
f(9, static_cast<T&&>(t).enum_field_ref()...);
112+
f(10, static_cast<T&&>(t).list_field_ref()...);
113+
f(11, static_cast<T&&>(t).set_field_ref()...);
114+
f(12, static_cast<T&&>(t).map_field_ref()...);
115+
}
116+
};
117+
118+
template <>
119+
struct ForEachField<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault> {
120+
template <typename F, typename... T>
121+
void operator()([[maybe_unused]] F&& f, [[maybe_unused]] T&&... t) const {
122+
f(0, static_cast<T&&>(t).bool_field_ref()...);
123+
f(1, static_cast<T&&>(t).byte_field_ref()...);
124+
f(2, static_cast<T&&>(t).short_field_ref()...);
125+
f(3, static_cast<T&&>(t).int_field_ref()...);
126+
f(4, static_cast<T&&>(t).long_field_ref()...);
127+
f(5, static_cast<T&&>(t).float_field_ref()...);
128+
f(6, static_cast<T&&>(t).double_field_ref()...);
129+
f(7, static_cast<T&&>(t).string_field_ref()...);
130+
f(8, static_cast<T&&>(t).binary_field_ref()...);
131+
f(9, static_cast<T&&>(t).enum_field_ref()...);
132+
f(10, static_cast<T&&>(t).list_field_ref()...);
133+
f(11, static_cast<T&&>(t).set_field_ref()...);
134+
f(12, static_cast<T&&>(t).map_field_ref()...);
135+
}
136+
};
97137
} // namespace detail
98138
} // namespace thrift
99139
} // namespace apache

‎thrift/compiler/test/fixtures/terse_write/out/cpp2_deprecated_terse_writ/gen-cpp2/deprecated_terse_write_metadata.cpp

+46
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,52 @@ StructMetadata<::facebook::thrift::test::terse_write::deprecated::CppRefStructFi
130130
}
131131
return res.first->second;
132132
}
133+
const ::apache::thrift::metadata::ThriftStruct&
134+
StructMetadata<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault>::gen(ThriftMetadata& metadata) {
135+
auto res = metadata.structs()->emplace("deprecated_terse_write.DeprecatedTerseWriteWithCustomDefault", ::apache::thrift::metadata::ThriftStruct{});
136+
if (!res.second) {
137+
return res.first->second;
138+
}
139+
::apache::thrift::metadata::ThriftStruct& deprecated_terse_write_DeprecatedTerseWriteWithCustomDefault = res.first->second;
140+
deprecated_terse_write_DeprecatedTerseWriteWithCustomDefault.name() = "deprecated_terse_write.DeprecatedTerseWriteWithCustomDefault";
141+
deprecated_terse_write_DeprecatedTerseWriteWithCustomDefault.is_union() = false;
142+
static const auto* const
143+
deprecated_terse_write_DeprecatedTerseWriteWithCustomDefault_fields = new std::array<EncodedThriftField, 13>{ {
144+
{ 1, "bool_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_BOOL_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 2, "byte_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_BYTE_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 3, "short_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 4, "int_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I32_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 5, "long_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I64_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 6, "float_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_FLOAT_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 7, "double_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_DOUBLE_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 8, "string_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_STRING_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 9, "binary_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_BINARY_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 10, "enum_field", false, std::make_unique<Enum<::facebook::thrift::test::terse_write::deprecated::MyEnum>>("deprecated_terse_write.MyEnum"), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 11, "list_field", false, std::make_unique<List>(std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE)), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 12, "set_field", false, std::make_unique<Set>(std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE)), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 13, "map_field", false, std::make_unique<Map>(std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE), std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE)), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, }};
145+
for (const auto& f : *deprecated_terse_write_DeprecatedTerseWriteWithCustomDefault_fields) {
146+
::apache::thrift::metadata::ThriftField field;
147+
field.id() = f.id;
148+
field.name() = f.name;
149+
field.is_optional() = f.is_optional;
150+
f.metadata_type_interface->writeAndGenType(*field.type(), metadata);
151+
field.structured_annotations() = f.structured_annotations;
152+
deprecated_terse_write_DeprecatedTerseWriteWithCustomDefault.fields()->push_back(std::move(field));
153+
}
154+
return res.first->second;
155+
}
156+
const ::apache::thrift::metadata::ThriftStruct&
157+
StructMetadata<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault>::gen(ThriftMetadata& metadata) {
158+
auto res = metadata.structs()->emplace("deprecated_terse_write.DeprecatedTerseWriteWithRedundantCustomDefault", ::apache::thrift::metadata::ThriftStruct{});
159+
if (!res.second) {
160+
return res.first->second;
161+
}
162+
::apache::thrift::metadata::ThriftStruct& deprecated_terse_write_DeprecatedTerseWriteWithRedundantCustomDefault = res.first->second;
163+
deprecated_terse_write_DeprecatedTerseWriteWithRedundantCustomDefault.name() = "deprecated_terse_write.DeprecatedTerseWriteWithRedundantCustomDefault";
164+
deprecated_terse_write_DeprecatedTerseWriteWithRedundantCustomDefault.is_union() = false;
165+
static const auto* const
166+
deprecated_terse_write_DeprecatedTerseWriteWithRedundantCustomDefault_fields = new std::array<EncodedThriftField, 13>{ {
167+
{ 1, "bool_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_BOOL_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 2, "byte_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_BYTE_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 3, "short_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 4, "int_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I32_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 5, "long_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I64_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 6, "float_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_FLOAT_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 7, "double_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_DOUBLE_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 8, "string_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_STRING_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 9, "binary_field", false, std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_BINARY_TYPE), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 10, "enum_field", false, std::make_unique<Enum<::facebook::thrift::test::terse_write::deprecated::MyEnum>>("deprecated_terse_write.MyEnum"), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 11, "list_field", false, std::make_unique<List>(std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE)), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 12, "set_field", false, std::make_unique<Set>(std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE)), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, { 13, "map_field", false, std::make_unique<Map>(std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE), std::make_unique<Primitive>(ThriftPrimitiveType::THRIFT_I16_TYPE)), std::vector<ThriftConstStruct>{ *cvStruct("cpp.DeprecatedTerseWrite", { }).cv_struct_ref(), }}, }};
168+
for (const auto& f : *deprecated_terse_write_DeprecatedTerseWriteWithRedundantCustomDefault_fields) {
169+
::apache::thrift::metadata::ThriftField field;
170+
field.id() = f.id;
171+
field.name() = f.name;
172+
field.is_optional() = f.is_optional;
173+
f.metadata_type_interface->writeAndGenType(*field.type(), metadata);
174+
field.structured_annotations() = f.structured_annotations;
175+
deprecated_terse_write_DeprecatedTerseWriteWithRedundantCustomDefault.fields()->push_back(std::move(field));
176+
}
177+
return res.first->second;
178+
}
133179

134180
} // namespace md
135181
} // namespace detail

‎thrift/compiler/test/fixtures/terse_write/out/cpp2_deprecated_terse_writ/gen-cpp2/deprecated_terse_write_metadata.h

+10
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,16 @@ class StructMetadata<::facebook::thrift::test::terse_write::deprecated::CppRefSt
4747
public:
4848
static const ::apache::thrift::metadata::ThriftStruct& gen(ThriftMetadata& metadata);
4949
};
50+
template <>
51+
class StructMetadata<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithCustomDefault> {
52+
public:
53+
static const ::apache::thrift::metadata::ThriftStruct& gen(ThriftMetadata& metadata);
54+
};
55+
template <>
56+
class StructMetadata<::facebook::thrift::test::terse_write::deprecated::DeprecatedTerseWriteWithRedundantCustomDefault> {
57+
public:
58+
static const ::apache::thrift::metadata::ThriftStruct& gen(ThriftMetadata& metadata);
59+
};
5060
} // namespace md
5161
} // namespace detail
5262
} // namespace thrift

0 commit comments

Comments
 (0)