minor refactor tests to consolidate common types

Summary: this is a minor refactor for frame parser tests to consolidate common test types to `TestUtil.h`

Reviewed By: AkramaMirza

Differential Revision: D59638541

fbshipit-source-id: 9526a55098a24103f6fae140e666429505a0fcaf

Author: avalonalex

thrift/lib/cpp2/transport/rocket/framing/parser/test/AllocatingParserStrategyTest.cpp

@@ -16,27 +16,12 @@
 
 #include <gtest/gtest.h>
 #include <thrift/lib/cpp2/transport/rocket/framing/parser/AllocatingParserStrategy.h>
+#include <thrift/lib/cpp2/transport/rocket/framing/parser/test/TestUtil.h>
 
 namespace apache {
 namespace thrift {
 namespace rocket {
 
-class FakeOwner {
- public:
-  void handleFrame(std::unique_ptr<folly::IOBuf> buf) {
-    frames_.push_back(std::move(buf));
-  }
-  bool incMemoryUsage(uint32_t n) {
-    memoryCounter_ += n;
-    return true;
-  }
-  void decMemoryUsage(uint32_t n) { memoryCounter_ -= n; }
-
-  std::vector<std::unique_ptr<folly::IOBuf>> frames_{};
-
-  uint32_t memoryCounter_ = 0;
-};
-
 ParserAllocatorType alloc = ParserAllocatorType();
 
 TEST(AllocatingParserStrategyTest, testAppendFrame) {

thrift/lib/cpp2/transport/rocket/framing/parser/test/FrameLengthParserStrategyTest.cpp

@@ -18,27 +18,12 @@
 
 #include <folly/io/IOBuf.h>
 #include <thrift/lib/cpp2/transport/rocket/framing/parser/FrameLengthParserStrategy.h>
+#include <thrift/lib/cpp2/transport/rocket/framing/parser/test/TestUtil.h>
 
 namespace apache {
 namespace thrift {
 namespace rocket {
 
-class FakeOwner {
- public:
-  void handleFrame(std::unique_ptr<folly::IOBuf> buf) {
-    frames_.push_back(std::move(buf));
-  }
-  bool incMemoryUsage(uint32_t n) {
-    memoryCounter_ += n;
-    return true;
-  }
-  void decMemoryUsage(uint32_t n) { memoryCounter_ -= n; }
-
-  std::vector<std::unique_ptr<folly::IOBuf>> frames_{};
-
-  uint32_t memoryCounter_ = 0;
-};
-
 TEST(FrameLengthParserTest, testAppendFrame) {
   FakeOwner owner;
   FrameLengthParserStrategy<FakeOwner> parser(owner);

thrift/lib/cpp2/transport/rocket/framing/parser/test/ParserStrategyTest.cpp

@@ -19,27 +19,12 @@
 #include <folly/io/IOBuf.h>
 #include <thrift/lib/cpp2/transport/rocket/framing/parser/FrameLengthParserStrategy.h>
 #include <thrift/lib/cpp2/transport/rocket/framing/parser/ParserStrategy.h>
+#include <thrift/lib/cpp2/transport/rocket/framing/parser/test/TestUtil.h>
 
 namespace apache {
 namespace thrift {
 namespace rocket {
 
-class FakeOwner {
- public:
-  void handleFrame(std::unique_ptr<folly::IOBuf> buf) {
-    frames_.push_back(std::move(buf));
-  }
-  bool incMemoryUsage(uint32_t n) {
-    memoryCounter_ += n;
-    return true;
-  }
-  void decMemoryUsage(uint32_t n) { memoryCounter_ -= n; }
-
-  std::vector<std::unique_ptr<folly::IOBuf>> frames_{};
-
-  uint32_t memoryCounter_ = 0;
-};
-
 TEST(ParserTest, testAppendFrame) {
   FakeOwner owner;
   ParserStrategy<FakeOwner, FrameLengthParserStrategy> parser(owner);

thrift/lib/cpp2/transport/rocket/framing/parser/test/TestUtil.h

@@ -0,0 +1,35 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+namespace apache::thrift::rocket {
+class FakeOwner {
+ public:
+  void handleFrame(std::unique_ptr<folly::IOBuf> buf) {
+    frames_.push_back(std::move(buf));
+  }
+  bool incMemoryUsage(uint32_t n) {
+    memoryCounter_ += n;
+    return true;
+  }
+  void decMemoryUsage(uint32_t n) { memoryCounter_ -= n; }
+
+  std::vector<std::unique_ptr<folly::IOBuf>> frames_{};
+
+  uint32_t memoryCounter_ = 0;
+};
+} // namespace apache::thrift::rocket