Skip to content

Commit 4ea8f4a

Browse files
Mizuchifacebook-github-bot
authored andcommitted
diff(src,dst) should generate empty patch if src == dst
Reviewed By: pranavtbhat Differential Revision: D68864929 fbshipit-source-id: d2dfee5952e65c84c1ce6be852a249f0a416d484
1 parent 1b400c6 commit 4ea8f4a

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

thrift/lib/cpp2/patch/test/DynamicPatchTest.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ void testOneWay(T src, T dst) {
100100
auto other =
101101
detail::createPatchFromObject<PatchType>(badge, patch.toObject());
102102
EXPECT_EQ(other.toObject(), patch.toObject());
103+
EXPECT_EQ(patch.empty(), src == dst);
103104
}
104105

105106
TEST(DynamicPatchTest, Binary) {
@@ -162,6 +163,7 @@ void testMapAndObject(
162163
auto patch = DiffVisitorBase{}.diff(objSrc, objDst);
163164
applyPatch(patch.toObject(), objSrc);
164165
EXPECT_EQ(objSrc, objDst);
166+
EXPECT_EQ(patch.empty(), src == dst);
165167

166168
if (mightBeUnion) {
167169
EXPECT_TRUE(patch.holds_alternative<DynamicUnknownPatch>(badge));

0 commit comments

Comments
 (0)