Unexport WithHeader

Summary: TSIA

Reviewed By: podtserkovskiy

Differential Revision: D92340530

fbshipit-source-id: 1bceb3d555080a9472d0532ff843e810862b0693

Author: echistyakov

thrift/lib/go/thrift/client.go

@@ -49,9 +49,9 @@ func WithProtocolID(id types.ProtocolID) ClientOption {
 	}
 }
 
-// WithHeader sets the transport to Header, protocol Header is implied here.
+// withHeader sets the transport to Header, protocol Header is implied here.
 // Deprecated: use WithUpgradeToRocket() instead.
-func WithHeader() ClientOption {
+func withHeader() ClientOption {
 	return func(opts *clientConfig) {
 		opts.transport = TransportIDHeader
 	}

thrift/lib/go/thrift/client_test.go

@@ -49,7 +49,7 @@ func TestCustomClientOptions(t *testing.T) {
 		require.Equal(t, types.ProtocolIDBinary, config.protocol)
 	})
 	t.Run("WithHeader", func(t *testing.T) {
-		config := newClientConfig(WithHeader())
+		config := newClientConfig(withHeader())
 		require.Equal(t, TransportIDHeader, config.transport)
 	})
 	t.Run("WithUpgradeToRocket", func(t *testing.T) {
@@ -195,7 +195,7 @@ func TestNewClientCreation(t *testing.T) {
 
 	t.Run("Header", func(t *testing.T) {
 		channel, err := NewClient(
-			WithHeader(),
+			withHeader(),
 			WithDialer(func() (net.Conn, error) {
 				return net.DialTimeout(addr.Network(), addr.String(), 5*time.Second)
 			}),

thrift/lib/go/thrift/server_test.go

@@ -276,7 +276,7 @@ func TestALPN(t *testing.T) {
 	require.NoError(t, err)
 
 	// Header
-	client3, err := createAlpnClient(WithHeader(), tlsDialerOption)
+	client3, err := createAlpnClient(withHeader(), tlsDialerOption)
 	require.NoError(t, err)
 	err = client3.Ping(context.TODO())
 	require.NoError(t, err)
@@ -923,7 +923,7 @@ func TestRocketServerFallbackToHeader(t *testing.T) {
 
 	// Create header client to trigger header transport processing
 	headerChannel, err := NewClient(
-		WithHeader(),
+		withHeader(),
 		WithTLS(addr.String(), 5*time.Second, clientConfig),
 		WithIoTimeout(5*time.Second),
 	)

thrift/lib/go/thrift/utils_test.go

@@ -191,7 +191,7 @@ func generateSelfSignedCerts() (clientConfig *tls.Config, serverConfig *tls.Conf
 func getClientTransportOption(serverTransport TransportID) ClientOption {
 	switch serverTransport {
 	case TransportIDHeader:
-		return WithHeader()
+		return withHeader()
 	case TransportIDUpgradeToRocket:
 		return WithUpgradeToRocket()
 	case TransportIDRocket: