remove HeadersFromContext

Summary: remove HeadersFromContext

Reviewed By: codyohl

Differential Revision: D59578817

fbshipit-source-id: c4863982d2caa5eaf55c1e4790f45a83310a9793

Author: awalterschulze

thrift/lib/go/thrift/context.go

@@ -24,10 +24,7 @@ import (
 
 type contextKey int
 
-const (
-	connInfoKey contextKey = iota
-	protocolKey
-)
+const connInfoKey contextKey = 0
 
 // ConnInfo contains connection information from clients of the SimpleServer.
 type ConnInfo struct {
@@ -77,13 +74,3 @@ func ConnInfoFromContext(ctx context.Context) (ConnInfo, bool) {
 	v, ok := ctx.Value(connInfoKey).(ConnInfo)
 	return v, ok
 }
-
-// Deprecated: Use thrift.GetHeaders
-func HeadersFromContext(ctx context.Context) map[string]string {
-	t, ok := ctx.Value(protocolKey).(Protocol)
-	if !ok {
-		// A nil map behaves like an empty map for reading.
-		return nil
-	}
-	return t.GetResponseHeaders()
-}

thrift/lib/go/thrift/context_headers.go

@@ -43,28 +43,19 @@ func AddHeader(ctx context.Context, key string, value string) (context.Context,
 	return ctx, nil
 }
 
-// WithHeaders attaches thrift headers to a ctx
+// WithHeaders attaches thrift headers to a ctx.
 func WithHeaders(ctx context.Context, headers map[string]string) context.Context {
 	return context.WithValue(ctx, headersKey, headers)
 }
 
 // GetHeaders gets thrift headers from ctx.
-// WithHeaders will set this, and if nothing is set it
-// will defer to thrift.HeadersFromContext
-// can return nil if there is no headers.
 func GetHeaders(ctx context.Context) map[string]string {
 	// check for headersKey
 	v, ok := ctx.Value(headersKey).(map[string]string)
 	if ok {
 		return v
 	}
-	// deprecated
-	t, ok := ctx.Value(protocolKey).(Protocol)
-	if !ok {
-		// A nil map behaves like an empty map for reading.
-		return nil
-	}
-	return t.GetResponseHeaders()
+	return nil
 }
 
 // Deprecated: RequestHeaders will eventually be private.