Make isinstance/issubclass checks pass when auto-migrate mode is passed for thrift.py3.{Struct,Union}

Summary:
When we're in auto-migrate mode, we want instance checks against `thrift.py3.Struct` to still pass (as there's a lot of user code that checks `isinstance(my_struct, thrift.py3.Struct)` to do some logic that is for thrift-py3 and otherwise do logic that is for thrift-py-deprecated.

This makes it such that for thrift-python structs/unions, `._fbthrift_auto_migrate_enabled()` is checked, which is a bool that gets set to true when auto-migrate is enabled, so in normal build mode, `isinstance(python_struct, thrift.py3.Struct)` returns `False`, but in auto-migrate mode returns `True`

Reviewed By: prakashgayasen

Differential Revision: D68765988

fbshipit-source-id: 8e93fd6c526969dfe98201e3b8a3d68d31f97670

Author: Filip Francetic

thrift/compiler/generate/templates/python/types/types.mustache

@@ -93,6 +93,10 @@ class {{> structs/unadapted_name}}{{!
             }}{{^struct:thrift_uri}}None{{/struct:thrift_uri}}
 
 {{#program:generate_immutable_types}}
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return {{#program:py3_auto_migrate?}}True{{/program:py3_auto_migrate?}}{{^program:py3_auto_migrate?}}False{{/program:py3_auto_migrate?}}
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__{{#struct:exception?}}exception{{/struct:exception?}}{{^struct:exception?}}struct{{/struct:exception?}}_{{> structs/unadapted_name}}()

thrift/compiler/test/fixtures/adapter/out/python_a/gen-python/a/thrift_types.py

@@ -70,6 +70,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyStruct()

thrift/compiler/test/fixtures/adapter/out/python_with_containers/gen-python/with_containers/thrift_types.py

@@ -51,6 +51,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct__fbthrift_unadapted_AnnotationWithContainers()
@@ -109,6 +113,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct__fbthrift_unadapted_MyStruct()

thrift/compiler/test/fixtures/basic/out/python/gen-python/test/fixtures/basic/module/thrift_types.py

@@ -136,6 +136,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return "test.dev/fixtures/basic/MyStruct"
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyStruct()
@@ -213,6 +217,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return "test.dev/fixtures/basic/Containers"
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_Containers()
@@ -257,6 +265,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return "test.dev/fixtures/basic/MyDataItem"
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyDataItem()
@@ -348,6 +360,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return "test.dev/fixtures/basic/MyUnion"
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyUnion()
@@ -439,6 +455,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return "test.dev/fixtures/basic/MyException"
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__exception_MyException()
@@ -528,6 +548,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return "test.dev/fixtures/basic/MyExceptionWithMessage"
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__exception_MyExceptionWithMessage()
@@ -588,6 +612,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return "test.dev/fixtures/basic/ReservedKeyword"
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_ReservedKeyword()
@@ -646,6 +674,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return "test.dev/fixtures/basic/UnionToBeRenamed"
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_UnionToBeRenamed()

thrift/compiler/test/fixtures/basic/out/python_service/gen-python/meta/example/thrift/service/thrift_types.py

@@ -39,6 +39,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_EchoRequest()
@@ -94,6 +98,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_EchoResponse()
@@ -152,6 +160,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__exception_WhisperException()

thrift/compiler/test/fixtures/complex-struct/out/python/gen-python/module/thrift_types.py

@@ -78,6 +78,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyStructFloatFieldThrowExp()
@@ -144,6 +148,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyStructMapFloatThrowExp()
@@ -496,6 +504,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyStruct()
@@ -562,6 +574,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_SimpleStruct()
@@ -848,6 +864,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_defaultStruct()
@@ -991,6 +1011,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyStructTypeDef()
@@ -1035,6 +1059,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyDataItem()
@@ -1148,6 +1176,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyUnion()
@@ -1239,6 +1271,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_MyUnionFloatFieldThrowExp()
@@ -1481,6 +1517,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_ComplexNestedStruct()
@@ -1569,6 +1609,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_TypeRemapped()
@@ -1616,6 +1660,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__exception_emptyXcep()
@@ -1683,6 +1731,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__exception_reqXcep()
@@ -1750,6 +1802,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__exception_optXcep()
@@ -1861,6 +1917,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__exception_complexException()
@@ -2310,6 +2370,10 @@ def __get_thrift_name__() -> str:
     def __get_thrift_uri__():
         return None
 
+    @classmethod
+    def _fbthrift_auto_migrate_enabled(cls):
+        return False
+
     @staticmethod
     def __get_metadata__():
         return _fbthrift_metadata__struct_Containers()