Skip to content

Commit 09eeded

Browse files
SamChou19815meta-codesync[bot]
authored andcommitted
[flow] Skip constraint caching for more kinds of use_ts
Summary: They don't seem to depend on the constraint cache to ensure termination. Changelog: [internal] Reviewed By: panagosg7 Differential Revision: D85766684 fbshipit-source-id: dce21c7fdf5ef2ef317ba0e12188fa59edbda55d
1 parent 63f5689 commit 09eeded

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/typing/flow_cache.ml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@ module FlowConstraint = struct
2929
* have defense against bad cyclic types. *)
3030
| (_, ConcretizeT _) ->
3131
false
32-
| (_, (BindT _ | CallT _ | MethodT _ | PrivateMethodT _ | ConstructorT _)) -> false
32+
| ( _,
33+
( BindT _ | CallT _ | MethodT _ | PrivateMethodT _ | ConstructorT _ | ObjRestT _
34+
| ObjTestT _ | ArrRestT _ )
35+
) ->
36+
false
3337
| _ ->
3438
(* Use ops are purely for better error messages: they should have no
3539
effect on type checking. However, recursively nested use ops can pose

0 commit comments

Comments
 (0)