[flow] remove check on keys of Omit

Summary:
This now matches TypeScript's behavior: https://www.typescriptlang.org/play/?#code/C4TwDgpgBAglC8UDyBbAlsAPAbwL4BooByAQyID4BuAKAGMB7AOwGdgoSAuWBKPSoA

Changelog: [errors] the `Omit<O, K>` utility type will not enforce that the provided keys `K` need to be part of `O`.

Reviewed By: gkz

Differential Revision: D89563453

fbshipit-source-id: 363623b3faf51bca89f4c69872bc9867cf101825

Author: panagosg7

lib/core.js

@@ -3184,7 +3184,7 @@ type Pick<O: interface {}, Keys: $Keys<O>> = {[key in Keys]: O[key]};
 /**
  * Omit specific fields from an object, e.g. Omit<O, 'foo' | 'bar'>
  */
-type Omit<O: interface {}, Keys: $Keys<O>> = $Omit<O, Keys>;
+type Omit<O: interface {}, Keys> = $Omit<O, Keys>;
 
 /**
  * Construct an object type using string literals as keys with the given type,

tests/mapped_type_utilities/mapped_type_utilities.exp

@@ -122,20 +122,6 @@ References:
               ^^^^^^^^ [2]
 
 
-Error ---------------------------------------------------------------------------------------------------- omit.js:65:43
-
-Cannot instantiate `Omit` because in type argument `Keys`: property `xxx` is missing in object type [1]. [prop-missing]
-
-   omit.js:65:43
-   65|   declare const x: Omit<{foo: 1, bar: 2}, 'xxx'>; // ERROR
-                                                 ^^^^^
-
-References:
-   omit.js:65:25
-   65|   declare const x: Omit<{foo: 1, bar: 2}, 'xxx'>; // ERROR
-                               ^^^^^^^^^^^^^^^^ [1]
-
-
 Error ----------------------------------------------------------------------------------------------------- pick.js:8:10
 
 Cannot assign `3` to `pickedO1.foo` because property `foo` is not writable. [cannot-write]
@@ -243,4 +229,4 @@ References:
 
 
 
-Found 16 errors
+Found 15 errors

tests/mapped_type_utilities/omit.js

@@ -62,5 +62,5 @@ type OmitInstance = Omit<C, 'foo'>;
 
 // Omitting non-existent property
 {
-  declare const x: Omit<{foo: 1, bar: 2}, 'xxx'>; // ERROR
+  declare const x: Omit<{foo: 1, bar: 2}, 'xxx'>; // OK
 }

tests/records/records.exp

@@ -273,9 +273,9 @@ Operation `Omit` [1] is not allowed on record `R` [2]. To fix, turn the record t
                              ^ [2]
 
 References:
-   <BUILTINS>/core.js:3187:46
-   3187| type Omit<O: interface {}, Keys: $Keys<O>> = $Omit<O, Keys>;
-                                                      ^^^^^^^^^^^^^^ [1]
+   <BUILTINS>/core.js:3187:36
+   3187| type Omit<O: interface {}, Keys> = $Omit<O, Keys>;
+                                            ^^^^^^^^^^^^^^ [1]
 
 
 Error -------------------------------------------------------------------------------------------- declaration.js:418:24

tests/type_destructors/tvar4.js

@@ -32,10 +32,7 @@ function fn3<T: {p: any}>(a: T => void): (Omit<T, 'p'>) => void {
 // number, but we expect a string.
 fn3((x: {foo: string, p: number}) => {})({foo: 42});
 
-// We error here because $Rest requires us to specify a p property in our object
-// type. But if we look at the implementation of fn3 this is a fine program
-// to accept.
-fn3((x: {foo: number}) => {})({foo: 42});
+fn3((x: {foo: number}) => {})({foo: 42}); // OK
 
 function fn4<T: {|p: any|}>(a: T => void): (T['p']) => void {
   // We error here because the implementation of {p: empty} ~> empty currently

tests/type_destructors/type_destructors.exp

@@ -390,27 +390,13 @@ References:
                      ^^^^^^ [2]
 
 
-Error ---------------------------------------------------------------------------------------------------- tvar4.js:38:1
-
-Cannot call `fn3` because in type argument `Keys`: property `p` is missing in object type [1]. [prop-missing]
-
-   tvar4.js:38:1
-   38| fn3((x: {foo: number}) => {})({foo: 42});
-       ^^^
-
-References:
-   tvar4.js:38:9
-   38| fn3((x: {foo: number}) => {})({foo: 42});
-               ^^^^^^^^^^^^^ [1]
-
-
-Error ---------------------------------------------------------------------------------------------------- tvar4.js:38:9
+Error ---------------------------------------------------------------------------------------------------- tvar4.js:35:9
 
 Cannot call `fn3` because in type argument `T`: property `p` is missing in object type [1] but exists in object
 type [2]. [incompatible-type]
 
-   tvar4.js:38:9
-   38| fn3((x: {foo: number}) => {})({foo: 42});
+   tvar4.js:35:9
+   35| fn3((x: {foo: number}) => {})({foo: 42}); // OK
                ^^^^^^^^^^^^^ [1]
 
 References:
@@ -419,62 +405,62 @@ References:
                        ^^^^^^^^ [2]
 
 
-Error --------------------------------------------------------------------------------------------------- tvar4.js:43:17
+Error --------------------------------------------------------------------------------------------------- tvar4.js:40:17
 
 Cannot call `a` with object literal bound to the first parameter because object literal [1] is incompatible with
 `T` [2]. [incompatible-type]
 
-   tvar4.js:43:17
-   43|   return p => a({p});
+   tvar4.js:40:17
+   40|   return p => a({p});
                        ^^^ [1]
 
 References:
-   tvar4.js:40:32
-   40| function fn4<T: {|p: any|}>(a: T => void): (T['p']) => void {
+   tvar4.js:37:32
+   37| function fn4<T: {|p: any|}>(a: T => void): (T['p']) => void {
                                       ^ [2]
 
 
-Error --------------------------------------------------------------------------------------------------- tvar4.js:47:31
+Error --------------------------------------------------------------------------------------------------- tvar4.js:44:31
 
 Cannot call `fn4(...)` with `42` bound to the first parameter because number [1] is incompatible with string [2].
 [incompatible-type]
 
-   tvar4.js:47:31
-   47| fn4((x: {|p: string|}) => {})(42);
+   tvar4.js:44:31
+   44| fn4((x: {|p: string|}) => {})(42);
                                      ^^ [1]
 
 References:
-   tvar4.js:47:14
-   47| fn4((x: {|p: string|}) => {})(42);
+   tvar4.js:44:14
+   44| fn4((x: {|p: string|}) => {})(42);
                     ^^^^^^ [2]
 
 
-Error ---------------------------------------------------------------------------------------------------- tvar4.js:51:1
+Error ---------------------------------------------------------------------------------------------------- tvar4.js:48:1
 
 Cannot call `fn4` because property `p` is missing in object type [1]. [prop-missing]
 
-   tvar4.js:51:1
-   51| fn4((x: {||}) => {})(42);
+   tvar4.js:48:1
+   48| fn4((x: {||}) => {})(42);
        ^^^
 
 References:
-   tvar4.js:51:9
-   51| fn4((x: {||}) => {})(42);
+   tvar4.js:48:9
+   48| fn4((x: {||}) => {})(42);
                ^^^^ [1]
 
 
-Error ---------------------------------------------------------------------------------------------------- tvar4.js:51:9
+Error ---------------------------------------------------------------------------------------------------- tvar4.js:48:9
 
 Cannot call `fn4` because in type argument `T`: property `p` is missing in object type [1] but exists in object
 type [2]. [incompatible-type]
 
-   tvar4.js:51:9
-   51| fn4((x: {||}) => {})(42);
+   tvar4.js:48:9
+   48| fn4((x: {||}) => {})(42);
                ^^^^ [1]
 
 References:
-   tvar4.js:40:17
-   40| function fn4<T: {|p: any|}>(a: T => void): (T['p']) => void {
+   tvar4.js:37:17
+   37| function fn4<T: {|p: any|}>(a: T => void): (T['p']) => void {
                        ^^^^^^^^^^ [2]
 
 
@@ -598,4 +584,4 @@ References:
 
 
 
-Found 38 errors
+Found 37 errors