Skip to content

Commit 5fd3637

Browse files
gkzmeta-codesync[bot]
authored andcommitted
[flow][docs] Re-record website docs flow-check snapshot for BinaryExpression loc change
Summary: D[80de37ca4933] ([flow][oxidation] Final batch of flow-parser-oxidized fix) aligned parser locations with hermes-parser. As part of that, `BinaryExpression` loc/range now spans its full operand subtree, including a trailing `AsExpression` on the right-hand side. For `1 === 1 as boolean` in `website/docs/types/casting.md` (parsed as `1 === (1 as boolean)` since `as` binds tighter than `===`), the enclosing `BinaryExpression` now covers columns 0–18 instead of just `1 === 1` (columns 0–7). The `invalid-compare` error caret therefore expands to cover the whole expression, which is the only diff against the snapshot: ``` -:2:1 2| 1 === 1 as boolean; // Error! - ^^^^^^^ + ^^^^^^^^^^^^^^^^^^ ``` Re-records `website/tests/docs_flow_check.exp` to match. Changelog: [internal] ___ Differential Revision: D106050488 fbshipit-source-id: ca3207befe3ad8013d4858664ee530a8457a0224
1 parent 7fb7e30 commit 5fd3637

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

website/tests/docs_flow_check.exp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3786,7 +3786,7 @@ lack a subtyping relationship. If that happens, you can cast one side to the uni
37863786

37873787
-:2:1
37883788
2| 1 === 1 as boolean; // Error!
3789-
^^^^^^^
3789+
^^^^^^^^^^^^^^^^^^
37903790

37913791
References:
37923792
-:2:1

0 commit comments

Comments
 (0)