[flow] Strip nominal identity of InstanceT going through ObjKitT

Summary:
This diff strips the nominal identity of `InstanceT` that's going through a `ObjKitT` transform, which includes operations like `Readonly`, `Partial`.

It's a long standing unsoundness issue, and it could also complicate nominal records work, if we want to reuse the `InstanceT` infra.

Changelog: [internal] Gated and default disabled for now

Reviewed By: gkz

Differential Revision: D85611050

fbshipit-source-id: ab8aa785c616c65b1e538fd73c4455ca57244d90

Author: SamChou19815

src/commands/commandUtils.ml

@@ -1468,6 +1468,7 @@ let make_options
     opt_facebook_fbt = FlowConfig.facebook_fbt flowconfig;
     opt_facebook_module_interop = FlowConfig.facebook_module_interop flowconfig;
     opt_ignore_non_literal_requires = FlowConfig.ignore_non_literal_requires flowconfig;
+    opt_instance_t_objkit_fix = FlowConfig.instance_t_objkit_fix flowconfig;
     opt_include_warnings =
       options_flags.include_warnings
       || options_flags.max_warnings <> None

src/commands/config/flowConfig.ml

@@ -86,6 +86,7 @@ module Opts = struct
     hook_compatibility_includes: string list;
     hook_compatibility_excludes: string list;
     ignore_non_literal_requires: bool;
+    instance_t_objkit_fix: bool;
     include_warnings: bool;
     jest_integration: bool;
     lazy_mode: lazy_mode option;
@@ -232,6 +233,7 @@ module Opts = struct
       hook_compatibility_includes = [];
       hook_compatibility_excludes = [];
       ignore_non_literal_requires = false;
+      instance_t_objkit_fix = false;
       include_warnings = false;
       jest_integration = false;
       lazy_mode = None;
@@ -706,6 +708,9 @@ module Opts = struct
   let ignore_non_literal_requires_parser =
     boolean (fun opts v -> Ok { opts with ignore_non_literal_requires = v })
 
+  let instance_t_objkit_fix_parser =
+    boolean (fun opts v -> Ok { opts with instance_t_objkit_fix = v })
+
   let lazy_mode_parser =
     enum
       [
@@ -1056,6 +1061,7 @@ module Opts = struct
         hook_compatibility_excludes_parser
       );
       ("experimental.facebook_module_interop", facebook_module_interop_parser);
+      ("experimental.instance_t_objkit_fix", instance_t_objkit_fix_parser);
       ("experimental.channel_mode", channel_mode_parser ~enabled:true);
       ("experimental.channel_mode.windows", channel_mode_parser ~enabled:Sys.win32);
       ("experimental.long_lived_workers", long_lived_workers_parser ~enabled:true);
@@ -1920,6 +1926,8 @@ let hook_compatibility c = c.options.Opts.hook_compatibility
 
 let ignore_non_literal_requires c = c.options.Opts.ignore_non_literal_requires
 
+let instance_t_objkit_fix c = c.options.Opts.instance_t_objkit_fix
+
 let include_warnings c = c.options.Opts.include_warnings
 
 let jest_integration c = c.options.Opts.jest_integration

src/commands/config/flowConfig.mli

@@ -150,6 +150,8 @@ val hook_compatibility : config -> bool
 
 val ignore_non_literal_requires : config -> bool
 
+val instance_t_objkit_fix : config -> bool
+
 val include_warnings : config -> bool
 
 val jest_integration : config -> bool

src/common/options.ml

@@ -137,6 +137,7 @@ type t = {
   opt_gc_worker: gc_control;
   opt_haste_module_ref_prefix: string option;
   opt_ignore_non_literal_requires: bool;
+  opt_instance_t_objkit_fix: bool;
   opt_include_suppressions: bool;
   opt_include_warnings: bool;
   opt_lazy_mode: bool;
@@ -377,6 +378,8 @@ let saved_state_verify opts = opts.opt_saved_state_verify
 
 let should_ignore_non_literal_requires opts = opts.opt_ignore_non_literal_requires
 
+let instance_t_objkit_fix opts = opts.opt_instance_t_objkit_fix
+
 let should_include_warnings opts = opts.opt_include_warnings
 
 let should_munge_underscores opts = opts.opt_munge_underscores

src/flow_dot_js.ml

@@ -124,6 +124,7 @@ let stub_metadata ~root ~checked =
     facebook_module_interop = false;
     file_options = Files.default_options;
     ignore_non_literal_requires = false;
+    instance_t_objkit_fix = false;
     max_workers = 0;
     missing_module_generators = [];
     no_unchecked_indexed_access = false;

src/services/code_action/__tests__/refactor_extract_utils_tests.ml

@@ -51,6 +51,7 @@ let stub_metadata ~root ~checked =
     facebook_module_interop = false;
     file_options;
     ignore_non_literal_requires = false;
+    instance_t_objkit_fix = false;
     max_workers = 0;
     missing_module_generators = [];
     no_unchecked_indexed_access = false;

src/typing/__tests__/type_hint_test.ml

@@ -46,6 +46,7 @@ let metadata =
     facebook_module_interop = false;
     file_options = Files.default_options;
     ignore_non_literal_requires = false;
+    instance_t_objkit_fix = false;
     max_workers = 0;
     missing_module_generators = [];
     no_unchecked_indexed_access = false;

src/typing/__tests__/typed_ast_test.ml

@@ -44,6 +44,7 @@ let metadata =
     facebook_module_interop = false;
     file_options = Files.default_options;
     ignore_non_literal_requires = false;
+    instance_t_objkit_fix = false;
     max_workers = 0;
     missing_module_generators = [];
     no_unchecked_indexed_access = false;

src/typing/context.ml

@@ -56,6 +56,7 @@ type metadata = {
   facebook_module_interop: bool;
   file_options: Files.options;
   ignore_non_literal_requires: bool;
+  instance_t_objkit_fix: bool;
   max_workers: int;
   missing_module_generators: (Str.regexp * string) list;
   no_unchecked_indexed_access: bool;
@@ -294,6 +295,7 @@ let metadata_of_options options =
     hook_compatibility_excludes = Options.hook_compatibility_excludes options;
     hook_compatibility_includes = Options.hook_compatibility_includes options;
     hook_compatibility = Options.hook_compatibility options;
+    instance_t_objkit_fix = Options.instance_t_objkit_fix options;
     react_rules = Options.react_rules options;
     dev_only_refinement_info_as_errors = Options.dev_only_refinement_info_as_errors options;
     enable_const_params = Options.enable_const_params options;

src/typing/context.mli

@@ -106,6 +106,7 @@ type metadata = {
   facebook_module_interop: bool;
   file_options: Files.options;
   ignore_non_literal_requires: bool;
+  instance_t_objkit_fix: bool;
   max_workers: int;
   missing_module_generators: (Str.regexp * string) list;
   no_unchecked_indexed_access: bool;