[flow] Do not negate refinements for match cases

Summary:
D85388235 will already do similar filtering based on the exhaustiveness checking system, so we don't need the negative refinements anymore.

Changelog: [internal]

Reviewed By: gkz

Differential Revision: D85961519

fbshipit-source-id: 7c2106084fb0fb0c2bd12127cde9b7f4acd458da

Author: SamChou19815

src/analysis/env_builder/__tests__/env_builder_refinement_test.ml

@@ -7490,7 +7490,7 @@ let%expect_test "match_object_pattern" =
   [%expect {|
     [
       (2, 1) to (2, 6) => {
-        {refinement = Or (Not (And (object, Not (Null))), Not (SentinelR type)); writes = {refinement = Or (Or (Not (And (object, Not (Null))), Not (SentinelR type)), Not (PropExistsR (value))); writes = (2, 1) to (2, 6): (`<match_root>`)}}
+        (2, 1) to (2, 6): (`<match_root>`)
       };
       (2, 8) to (2, 9) => {
         Global x
@@ -7502,7 +7502,7 @@ let%expect_test "match_object_pattern" =
         (3, 29) to (3, 30): (`a`)
       };
       (4, 2) to (4, 2) => {
-        {refinement = And (And (object, Not (Null)), SentinelR type); writes = {refinement = Or (Or (Not (And (object, Not (Null))), Not (SentinelR type)), Not (PropExistsR (value))); writes = (2, 1) to (2, 6): (`<match_root>`)}}
+        {refinement = And (And (object, Not (Null)), SentinelR type); writes = (2, 1) to (2, 6): (`<match_root>`)}
       }]
   |}]
 
@@ -7517,7 +7517,7 @@ let%expect_test "match_array_pattern" =
   [%expect {|
     [
       (2, 1) to (2, 6) => {
-        {refinement = Or (Not (And (isArray, array length === 1)), Not (SentinelR 0)); writes = {refinement = Or (Not (And (isArray, array length === 2)), Not (SentinelR 0)); writes = (2, 1) to (2, 6): (`<match_root>`)}}
+        (2, 1) to (2, 6): (`<match_root>`)
       };
       (2, 8) to (2, 9) => {
         Global x
@@ -7529,7 +7529,7 @@ let%expect_test "match_array_pattern" =
         (3, 29) to (3, 30): (`a`)
       };
       (4, 2) to (4, 2) => {
-        {refinement = And (And (isArray, array length === 1), SentinelR 0); writes = {refinement = Or (Not (And (isArray, array length === 2)), Not (SentinelR 0)); writes = (2, 1) to (2, 6): (`<match_root>`)}}
+        {refinement = And (And (isArray, array length === 1), SentinelR 0); writes = (2, 1) to (2, 6): (`<match_root>`)}
       }]
   |}]
 
@@ -7543,7 +7543,7 @@ let%expect_test "match_instance_pattern" =
   [%expect {|
     [
       (2, 1) to (2, 6) => {
-        {refinement = Or (Not (instanceof), Not (SentinelR b)); writes = {refinement = Or (Not (instanceof), Not (SentinelR a)); writes = (2, 1) to (2, 6): (`<match_root>`)}}
+        (2, 1) to (2, 6): (`<match_root>`)
       };
       (2, 8) to (2, 9) => {
         Global x
@@ -7558,7 +7558,7 @@ let%expect_test "match_instance_pattern" =
         (3, 22) to (3, 23): (`b`)
       };
       (4, 2) to (4, 2) => {
-        {refinement = And (instanceof, SentinelR b); writes = {refinement = Or (Not (instanceof), Not (SentinelR a)); writes = (2, 1) to (2, 6): (`<match_root>`)}}
+        {refinement = And (instanceof, SentinelR b); writes = (2, 1) to (2, 6): (`<match_root>`)}
       };
       (4, 2) to (4, 5) => {
         Global Foo

src/analysis/env_builder/name_resolver.ml

@@ -3034,7 +3034,7 @@ module Make (Context : C) (FlowAPIUtils : F with type cx = Context.t) :
           let env0 = this#env_snapshot in
           let lexical_hoist = new lexical_hoister ~flowmin_compatibility:false ~enable_enums in
           let bindings = lexical_hoist#eval lexical_hoist#match_pattern pattern in
-          let (completion_state, test_refinements) =
+          let completion_state =
             this#with_bindings ~lexical:true case_loc bindings (fun _ ->
                 this#push_refinement_scope empty_refinements;
                 let arg =
@@ -3043,7 +3043,6 @@ module Make (Context : C) (FlowAPIUtils : F with type cx = Context.t) :
                   )
                 in
                 this#visit_match_pattern ~arg pattern;
-                let test_refinements = this#peek_new_refinements () in
                 (match this#get_val_of_expression arg with
                 | Some refined_value ->
                   let values =
@@ -3067,19 +3066,13 @@ module Make (Context : C) (FlowAPIUtils : F with type cx = Context.t) :
                       ignore @@ on_case_body body
                   )
                 in
-                (completion_state, test_refinements)
+                completion_state
             )
           in
           let body_env_no_refinements = this#env_snapshot_without_latest_refinements in
           let body_env_with_refinements = this#env_snapshot in
           this#pop_refinement_scope ();
           this#reset_env env0;
-          if Option.is_none guard then (
-            (* If there is a guard, it's possible the case didn't match
-               because of it, not because the pattern didn't match. *)
-            this#push_refinement_scope test_refinements;
-            this#negate_new_refinements ()
-          );
           (body_env_no_refinements, body_env_with_refinements, completion_state)
 
       method private visit_match_pattern ~arg root_pattern =