[flow] Make ts_utility_syntax default to true [PickRequest:2257211811458630]

marcoww6 · meta-codesync[bot] · commit fa1b6e5f5edf · 2025-11-05T11:23:05.000-08:00
Summary:
I think relay has some open source customers so we should make ts_utility_syntax to default to true so it passed open source build check (e.g. relay-opensource-build-check signal in D86245770)

Changelog: [internal]

Reviewed By: panagosg7

Differential Revision:
D86252752

Merged By: marcoww

Merged Revision: c7b08ef1a9fcb2a2555f481bf8742659b4737db0

fbshipit-source-id: 25893fadd2f70b92f3fe2534144accb684970232
diff --git a/newtests/lsp/code-action/quickfix/__snapshots__/quickfix-add-annotation-for-invariant-subtyping-error-1.json b/newtests/lsp/code-action/quickfix/__snapshots__/quickfix-add-annotation-for-invariant-subtyping-error-1.json
@@ -52,7 +52,7 @@
                   "character": 29
                 }
               },
-              "newText": "$ReadOnly<{ v: string | number }>"
+              "newText": "Readonly<{ v: string | number }>"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/quickfix/__snapshots__/quickfix-add-annotation-for-invariant-subtyping-error-2.json b/newtests/lsp/code-action/quickfix/__snapshots__/quickfix-add-annotation-for-invariant-subtyping-error-2.json
@@ -52,7 +52,7 @@
                   "character": 51
                 }
               },
-              "newText": "$ReadOnly<{ v1: string | number, v2: string | number }>"
+              "newText": "Readonly<{ v1: string | number, v2: string | number }>"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/quickfix/__snapshots__/quickfix-add-annotation-for-invariant-subtyping-error-3.json b/newtests/lsp/code-action/quickfix/__snapshots__/quickfix-add-annotation-for-invariant-subtyping-error-3.json
@@ -52,7 +52,7 @@
                   "character": 21
                 }
               },
-              "newText": "$ReadOnly<{ v?: string }>"
+              "newText": "Readonly<{ v?: string }>"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-keyof-type.json b/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-keyof-type.json
@@ -1,38 +1,4 @@
 {
   "method": "textDocument/codeAction",
-  "result": [
-    {
-      "title": "Convert to `$Keys<T>`",
-      "kind": "quickfix",
-      "diagnostics": [],
-      "edit": {
-        "changes": {
-          "<PLACEHOLDER_PROJECT_URL>/fix-keyof.js": [
-            {
-              "range": {
-                "start": {
-                  "line": 2,
-                  "character": 9
-                },
-                "end": {
-                  "line": 2,
-                  "character": 16
-                }
-              },
-              "newText": "$Keys<O>"
-            }
-          ]
-        }
-      },
-      "command": {
-        "title": "",
-        "command": "log:org.flow:<PLACEHOLDER_PROJECT_URL>",
-        "arguments": [
-          "textDocument/codeAction",
-          "convert_keyof_type",
-          "Convert to `$Keys<T>`"
-        ]
-      }
-    }
-  ]
+  "result": []
 }
diff --git a/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-non-nullable-type.json b/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-non-nullable-type.json
@@ -1,38 +1,4 @@
 {
   "method": "textDocument/codeAction",
-  "result": [
-    {
-      "title": "Convert to `$NonMaybeType`",
-      "kind": "quickfix",
-      "diagnostics": [],
-      "edit": {
-        "changes": {
-          "<PLACEHOLDER_PROJECT_URL>/fix-nonnullable-type.js": [
-            {
-              "range": {
-                "start": {
-                  "line": 1,
-                  "character": 9
-                },
-                "end": {
-                  "line": 1,
-                  "character": 20
-                }
-              },
-              "newText": "$NonMaybeType"
-            }
-          ]
-        }
-      },
-      "command": {
-        "title": "",
-        "command": "log:org.flow:<PLACEHOLDER_PROJECT_URL>",
-        "arguments": [
-          "textDocument/codeAction",
-          "convert_NonNullable_type",
-          "Convert to `$NonMaybeType`"
-        ]
-      }
-    }
-  ]
+  "result": []
 }
diff --git a/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-readonly-array-no-dollar-type.json b/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-readonly-array-no-dollar-type.json
@@ -1,38 +1,4 @@
 {
   "method": "textDocument/codeAction",
-  "result": [
-    {
-      "title": "Convert to `$ReadOnlyArray`",
-      "kind": "quickfix",
-      "diagnostics": [],
-      "edit": {
-        "changes": {
-          "<PLACEHOLDER_PROJECT_URL>/fix-readonlyarray-type.js": [
-            {
-              "range": {
-                "start": {
-                  "line": 1,
-                  "character": 9
-                },
-                "end": {
-                  "line": 1,
-                  "character": 22
-                }
-              },
-              "newText": "$ReadOnlyArray"
-            }
-          ]
-        }
-      },
-      "command": {
-        "title": "",
-        "command": "log:org.flow:<PLACEHOLDER_PROJECT_URL>",
-        "arguments": [
-          "textDocument/codeAction",
-          "convert_ReadonlyArray_type",
-          "Convert to `$ReadOnlyArray`"
-        ]
-      }
-    }
-  ]
+  "result": []
 }
diff --git a/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-readonly-map-no-dollar-type.json b/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-readonly-map-no-dollar-type.json
@@ -1,38 +1,4 @@
 {
   "method": "textDocument/codeAction",
-  "result": [
-    {
-      "title": "Convert to `$ReadOnlyMap`",
-      "kind": "quickfix",
-      "diagnostics": [],
-      "edit": {
-        "changes": {
-          "<PLACEHOLDER_PROJECT_URL>/fix-readonlymap-type.js": [
-            {
-              "range": {
-                "start": {
-                  "line": 1,
-                  "character": 9
-                },
-                "end": {
-                  "line": 1,
-                  "character": 20
-                }
-              },
-              "newText": "$ReadOnlyMap"
-            }
-          ]
-        }
-      },
-      "command": {
-        "title": "",
-        "command": "log:org.flow:<PLACEHOLDER_PROJECT_URL>",
-        "arguments": [
-          "textDocument/codeAction",
-          "convert_ReadonlyMap_type",
-          "Convert to `$ReadOnlyMap`"
-        ]
-      }
-    }
-  ]
+  "result": []
 }
diff --git a/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-readonly-set-no-dollar-type.json b/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-readonly-set-no-dollar-type.json
@@ -1,38 +1,4 @@
 {
   "method": "textDocument/codeAction",
-  "result": [
-    {
-      "title": "Convert to `$ReadOnlySet`",
-      "kind": "quickfix",
-      "diagnostics": [],
-      "edit": {
-        "changes": {
-          "<PLACEHOLDER_PROJECT_URL>/fix-readonlyset-type.js": [
-            {
-              "range": {
-                "start": {
-                  "line": 1,
-                  "character": 9
-                },
-                "end": {
-                  "line": 1,
-                  "character": 20
-                }
-              },
-              "newText": "$ReadOnlySet"
-            }
-          ]
-        }
-      },
-      "command": {
-        "title": "",
-        "command": "log:org.flow:<PLACEHOLDER_PROJECT_URL>",
-        "arguments": [
-          "textDocument/codeAction",
-          "convert_ReadonlySet_type",
-          "Convert to `$ReadOnlySet`"
-        ]
-      }
-    }
-  ]
+  "result": []
 }
diff --git a/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-ts-readonly-type.json b/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-ts-readonly-type.json
@@ -1,38 +1,4 @@
 {
   "method": "textDocument/codeAction",
-  "result": [
-    {
-      "title": "Convert to `$ReadOnly`",
-      "kind": "quickfix",
-      "diagnostics": [],
-      "edit": {
-        "changes": {
-          "<PLACEHOLDER_PROJECT_URL>/fix-readonly-type.js": [
-            {
-              "range": {
-                "start": {
-                  "line": 1,
-                  "character": 9
-                },
-                "end": {
-                  "line": 1,
-                  "character": 17
-                }
-              },
-              "newText": "$ReadOnly"
-            }
-          ]
-        }
-      },
-      "command": {
-        "title": "",
-        "command": "log:org.flow:<PLACEHOLDER_PROJECT_URL>",
-        "arguments": [
-          "textDocument/codeAction",
-          "convert_Readonly_type",
-          "Convert to `$ReadOnly`"
-        ]
-      }
-    }
-  ]
+  "result": []
 }
diff --git a/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-unknown-type.json b/newtests/lsp/code-action/quickfix/ts_and_legacy_syntax/__snapshots__/quickfix-unknown-type.json
@@ -1,38 +1,4 @@
 {
   "method": "textDocument/codeAction",
-  "result": [
-    {
-      "title": "Convert to `mixed`",
-      "kind": "quickfix",
-      "diagnostics": [],
-      "edit": {
-        "changes": {
-          "<PLACEHOLDER_PROJECT_URL>/fix-unknown-type.js": [
-            {
-              "range": {
-                "start": {
-                  "line": 2,
-                  "character": 9
-                },
-                "end": {
-                  "line": 2,
-                  "character": 16
-                }
-              },
-              "newText": "mixed"
-            }
-          ]
-        }
-      },
-      "command": {
-        "title": "",
-        "command": "log:org.flow:<PLACEHOLDER_PROJECT_URL>",
-        "arguments": [
-          "textDocument/codeAction",
-          "convert_unknown_type",
-          "Convert to `mixed`"
-        ]
-      }
-    }
-  ]
+  "result": []
 }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_array_type_legacy_flow_syntax-2.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_array_type_legacy_flow_syntax-2.json
@@ -19,7 +19,7 @@
                   "character": 14
                 }
               },
-              "newText": "$ReadOnlyArray"
+              "newText": "ReadonlyArray"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_array_type_legacy_flow_syntax-4.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_array_type_legacy_flow_syntax-4.json
@@ -19,7 +19,7 @@
                   "character": 14
                 }
               },
-              "newText": "$ReadOnlyArray"
+              "newText": "ReadonlyArray"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_array_type_legacy_flow_syntax-5.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_array_type_legacy_flow_syntax-5.json
@@ -19,7 +19,7 @@
                   "character": 20
                 }
               },
-              "newText": "$ReadOnlyArray"
+              "newText": "ReadonlyArray"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_map_and_set_legacy_flow_syntax-1.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_map_and_set_legacy_flow_syntax-1.json
@@ -19,7 +19,7 @@
                   "character": 12
                 }
               },
-              "newText": "$ReadOnlyMap"
+              "newText": "ReadonlyMap"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_map_and_set_legacy_flow_syntax-2.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_map_and_set_legacy_flow_syntax-2.json
@@ -19,7 +19,7 @@
                   "character": 12
                 }
               },
-              "newText": "$ReadOnlySet"
+              "newText": "ReadonlySet"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_map_and_set_legacy_flow_syntax-4.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_map_and_set_legacy_flow_syntax-4.json
@@ -19,7 +19,7 @@
                   "character": 12
                 }
               },
-              "newText": "$ReadOnlySet"
+              "newText": "ReadonlySet"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_map_and_set_legacy_flow_syntax-5.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_map_and_set_legacy_flow_syntax-5.json
@@ -19,7 +19,7 @@
                   "character": 16
                 }
               },
-              "newText": "$ReadOnlySet"
+              "newText": "ReadonlySet"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-2.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-2.json
@@ -19,7 +19,7 @@
                   "character": 22
                 }
               },
-              "newText": "$ReadOnly<{ foo: string }>"
+              "newText": "Readonly<{ foo: string }>"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-4.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-4.json
@@ -19,7 +19,7 @@
                   "character": 29
                 }
               },
-              "newText": "$ReadOnly<{ foo: { bar: string } }>"
+              "newText": "Readonly<{ foo: { bar: string } }>"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-5.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-5.json
@@ -19,7 +19,7 @@
                   "character": 28
                 }
               },
-              "newText": "$ReadOnly<{ bar: string }>"
+              "newText": "Readonly<{ bar: string }>"
             }
           ]
         }
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-6.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-6.json
diff --git a/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-7.json b/newtests/lsp/code-action/refactor/readonly_conversion/__snapshots__/convert_object_type_legacy_flow_syntax-7.json
diff --git a/src/commands/config/flowConfig.ml b/src/commands/config/flowConfig.ml
diff --git a/tests/try/try.exp b/tests/try/try.exp

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@`
`52`	`52`	`"character": 29`
`53`	`53`	`}`
`54`	`54`	`},`
`55`		`- "newText": "$ReadOnly<{ v: string \| number }>"`
	`55`	`+ "newText": "Readonly<{ v: string \| number }>"`
`56`	`56`	`}`
`57`	`57`	`]`
`58`	`58`	`}`