Skip to content

Commit 076b153

Browse files
generatedunixname893464919433493meta-codesync[bot]
authored andcommitted
Fix incorrect alignment for Fiber::userBuffer_
Summary: D88106410 replaced `std::aligned_storage` with `folly::aligned_storage_t` across folly. In `Fiber.h`, `userBuffer_` was incorrectly changed from `std::aligned_storage<kUserBufferSize>::type` (default alignment) to `folly::aligned_storage_t<kUserBufferSize, cacheline_align_v>` (64-byte cacheline alignment). The `cacheline_align_v` was not in the original code — it was mistakenly copied from the adjacent `Buffer` typedef. This removes the spurious `cacheline_align_v` argument so `folly::aligned_storage_t<kUserBufferSize>` uses its default alignment, matching the original `std::aligned_storage<256>::type` behavior. Reviewed By: dmm-fb, yfeldblum Differential Revision: D95415011 fbshipit-source-id: a6bef72cd1caf3ee7058157a61fddceb555560de
1 parent 2c9728d commit 076b153

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

folly/fibers/Fiber.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ class Fiber {
161161
folly::AtomicIntrusiveLinkedListHook<Fiber> nextRemoteReady_;
162162

163163
static constexpr size_t kUserBufferSize = 256;
164-
folly::aligned_storage_t<kUserBufferSize, cacheline_align_v> userBuffer_;
164+
folly::aligned_storage_t<kUserBufferSize> userBuffer_;
165165

166166
void* getUserBuffer();
167167

0 commit comments

Comments
 (0)