Fix CQS signal modernize-use-nodiscard in fbcode/proxygen/lib

Differential Revision: D92809129

fbshipit-source-id: c1ca7e6cc9d9c902f556f7d8cbbf25a0b4a1a674

Author: generatedunixname1587093422349604

third-party/proxygen/src/proxygen/lib/http/session/HTTPSession.h

@@ -980,7 +980,7 @@ class HTTPSession
       session_->flowControlTimeoutExpired();
     }
 
-    std::chrono::milliseconds getTimeoutDuration() const {
+    [[nodiscard]] std::chrono::milliseconds getTimeoutDuration() const {
       return duration_;
     }
 

third-party/proxygen/src/proxygen/lib/http/session/HTTPSessionAcceptor.h

@@ -46,7 +46,7 @@ class HTTPSessionAcceptor
   /**
    * Access the default error page generator.
    */
-  const HTTPErrorPage* getDefaultErrorPage() const {
+  [[nodiscard]] const HTTPErrorPage* getDefaultErrorPage() const {
     return defaultErrorPage_.get();
   }
 

third-party/proxygen/src/proxygen/lib/http/session/HTTPSessionBase.h

@@ -169,7 +169,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
                           uint32_t maxEventsPerInterval,
                           std::chrono::milliseconds intervalDuration);
 
-  InfoCallback* getInfoCallback() const {
+  [[nodiscard]] InfoCallback* getInfoCallback() const {
     return infoCallback_;
   }
 
@@ -178,13 +178,14 @@ class HTTPSessionBase : public wangle::ManagedConnection {
 
   virtual void setSessionStats(HTTPSessionStats* stats);
 
-  virtual HTTPTransaction::Transport::Type getType() const noexcept = 0;
+  [[nodiscard]] virtual HTTPTransaction::Transport::Type getType()
+      const noexcept = 0;
 
   virtual folly::AsyncTransport* getTransport() = 0;
 
-  virtual const folly::AsyncTransport* getTransport() const = 0;
+  [[nodiscard]] virtual const folly::AsyncTransport* getTransport() const = 0;
 
-  virtual folly::EventBase* getEventBase() const = 0;
+  [[nodiscard]] virtual folly::EventBase* getEventBase() const = 0;
 
   /**
    * Called by handleErrorDirectly (when handling parse errors) if the
@@ -193,34 +194,35 @@ class HTTPSessionBase : public wangle::ManagedConnection {
   HTTPTransaction::Handler* getParseErrorHandler(HTTPTransaction* txn,
                                                  const HTTPException& error);
 
-  virtual bool hasActiveTransactions() const = 0;
+  [[nodiscard]] virtual bool hasActiveTransactions() const = 0;
 
   /**
    * Returns true iff a new outgoing transaction can be made on this session
    */
-  virtual bool supportsMoreTransactions() const {
+  [[nodiscard]] virtual bool supportsMoreTransactions() const {
     return (getNumOutgoingStreams() < getMaxConcurrentOutgoingStreams());
   }
 
-  virtual uint32_t getNumStreams() const = 0;
+  [[nodiscard]] virtual uint32_t getNumStreams() const = 0;
 
-  virtual uint32_t getNumOutgoingStreams() const = 0;
+  [[nodiscard]] virtual uint32_t getNumOutgoingStreams() const = 0;
 
   // SimpleSessionPool
-  uint32_t getHistoricalMaxOutgoingStreams() const {
+  [[nodiscard]] uint32_t getHistoricalMaxOutgoingStreams() const {
     return historicalMaxOutgoingStreams_;
   }
 
-  virtual uint32_t getNumIncomingStreams() const = 0;
+  [[nodiscard]] virtual uint32_t getNumIncomingStreams() const = 0;
 
-  virtual uint32_t getMaxConcurrentOutgoingStreamsRemote() const = 0;
+  [[nodiscard]] virtual uint32_t getMaxConcurrentOutgoingStreamsRemote()
+      const = 0;
 
-  uint32_t getMaxConcurrentOutgoingStreams() const {
+  [[nodiscard]] uint32_t getMaxConcurrentOutgoingStreams() const {
     return std::min(maxConcurrentOutgoingStreamsConfig_,
                     getMaxConcurrentOutgoingStreamsRemote());
   }
 
-  HTTPSessionController* getController() const {
+  [[nodiscard]] HTTPSessionController* getController() const {
     return controller_;
   }
 
@@ -231,7 +233,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
     initCodecHeaderIndexingStrategy();
   }
 
-  ConnectionCloseReason getConnectionCloseReason() const {
+  [[nodiscard]] ConnectionCloseReason getConnectionCloseReason() const {
     return closeReason_;
   }
 
@@ -240,7 +242,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
     codec_.add<Filter>(std::forward<Args>(args)...);
   }
 
-  virtual CodecProtocol getCodecProtocol() const {
+  [[nodiscard]] virtual CodecProtocol getCodecProtocol() const {
     return codec_->getProtocol();
   }
 
@@ -271,7 +273,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
     h2PrioritiesEnabled_ = enabled;
   }
 
-  virtual bool getHTTP2PrioritiesEnabled() const {
+  [[nodiscard]] virtual bool getHTTP2PrioritiesEnabled() const {
     return h2PrioritiesEnabled_;
   }
 
@@ -294,7 +296,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
    * Get/Set the number of egress bytes this session will buffer before
    * pausing all transactions' egress.
    */
-  uint32_t getWriteBufferLimit() const {
+  [[nodiscard]] uint32_t getWriteBufferLimit() const {
     return writeBufLimit_;
   }
 
@@ -338,7 +340,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
     return 0;
   }
 
-  uint64_t getNumTxnServed() const {
+  [[nodiscard]] uint64_t getNumTxnServed() const {
     return transactionSeqNo_;
   }
 
@@ -354,13 +356,16 @@ class HTTPSessionBase : public wangle::ManagedConnection {
   }
 
   // public HTTPTransaction::Transport overrides
-  virtual const folly::SocketAddress& getLocalAddress() const noexcept {
+  [[nodiscard]] virtual const folly::SocketAddress& getLocalAddress()
+      const noexcept {
     return localAddr_;
   }
-  const folly::SocketAddress& getPeerAddress() const noexcept override {
+  [[nodiscard]] const folly::SocketAddress& getPeerAddress()
+      const noexcept override {
     return peerAddr_;
   }
-  const wangle::TransportInfo& getSetupTransportInfo() const noexcept
+  [[nodiscard]] const wangle::TransportInfo& getSetupTransportInfo()
+      const noexcept
   /*override*/ {
     return transportInfo_;
   }
@@ -424,7 +429,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
 
   using FilterIteratorFn = std::function<void(HTTPCodecFilter*)>;
 
-  virtual bool isDetachable(bool checkSocket) const = 0;
+  [[nodiscard]] virtual bool isDetachable(bool checkSocket) const = 0;
 
   virtual void attachThreadLocals(
       folly::EventBase* eventBase,
@@ -447,18 +452,18 @@ class HTTPSessionBase : public wangle::ManagedConnection {
   virtual HTTPTransaction* newTransaction(
       HTTPTransaction::Handler* handler) = 0;
 
-  virtual bool isReplaySafe() const = 0;
+  [[nodiscard]] virtual bool isReplaySafe() const = 0;
 
   /**
    * Returns true if the underlying transport can be used again in a new
    * request.
    */
-  virtual bool isReusable() const = 0;
+  [[nodiscard]] virtual bool isReusable() const = 0;
 
   /**
    * Returns true if the session is shutting down
    */
-  virtual bool isClosing() const = 0;
+  [[nodiscard]] virtual bool isClosing() const = 0;
 
   /**
    * Drains the current transactions and prevents new transactions from being
@@ -556,7 +561,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
     CHECK_EQ(codec_->getTransportDirection(), TransportDirection::DOWNSTREAM);
     enableServerEarlyResponse_ = codec_->supportsParallelRequests();
   }
-  bool getServerEarlyResponseEnabled() const {
+  [[nodiscard]] bool getServerEarlyResponseEnabled() const {
     return enableServerEarlyResponse_;
   }
 
@@ -571,7 +576,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
     return pendingWriteSize_ + pendingWriteSizeDelta_ > 0;
   }
 
-  uint64_t getPendingWriteSize() const {
+  [[nodiscard]] uint64_t getPendingWriteSize() const {
     return pendingWriteSize_;
   }
 
@@ -592,7 +597,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
     latestActive_ = getCurrentTime();
   }
 
-  bool ingressLimitExceeded() const {
+  [[nodiscard]] bool ingressLimitExceeded() const {
     return pendingReadSize_ > readBufLimit_;
   }
   void onCreateTransaction() {
@@ -733,7 +738,7 @@ class HTTPSessionBase : public wangle::ManagedConnection {
   HTTPSessionController* controller_{nullptr};
 
   // private ManagedConnection methods
-  std::chrono::milliseconds getIdleTime() const override {
+  [[nodiscard]] std::chrono::milliseconds getIdleTime() const override {
     if (timePointInitialized(latestActive_)) {
       return millisecondsSince(latestActive_);
     } else {

third-party/proxygen/src/proxygen/lib/http/session/HTTPSessionController.h

@@ -91,21 +91,24 @@ class HTTPSessionController {
   /**
    * Optionally allow the session to query custom graceful shutdown timeout.
    */
-  virtual std::chrono::milliseconds getGracefulShutdownTimeout() const {
+  [[nodiscard]] virtual std::chrono::milliseconds getGracefulShutdownTimeout()
+      const {
     return std::chrono::milliseconds(0);
   }
 
   /**
    * Optionally allow the session to query custom flow control timeout.
    */
-  virtual std::chrono::milliseconds getSessionFlowControlTimeout() const {
+  [[nodiscard]] virtual std::chrono::milliseconds getSessionFlowControlTimeout()
+      const {
     return std::chrono::milliseconds(0);
   }
 
   /**
    * Returns the H2 header indexing strategy to be employed by the session
    */
-  virtual const HeaderIndexingStrategy* getHeaderIndexingStrategy() const {
+  [[nodiscard]] virtual const HeaderIndexingStrategy*
+  getHeaderIndexingStrategy() const {
     return HeaderIndexingStrategy::getDefaultInstance();
   }
 };

third-party/proxygen/src/proxygen/lib/http/session/HTTPTransaction.h

@@ -499,25 +499,27 @@ class HTTPTransaction
 
     virtual void notifyEgressBodyBuffered(int64_t bytes) noexcept = 0;
 
-    const folly::SocketAddress& getLocalAddress() const noexcept override = 0;
+    [[nodiscard]] const folly::SocketAddress& getLocalAddress()
+        const noexcept override = 0;
 
-    const folly::SocketAddress& getPeerAddress() const noexcept override = 0;
+    [[nodiscard]] const folly::SocketAddress& getPeerAddress()
+        const noexcept override = 0;
 
     [[nodiscard]] virtual std::chrono::seconds getLatestIdleTime() const = 0;
 
     virtual void describe(std::ostream&) const = 0;
 
-    virtual const wangle::TransportInfo& getSetupTransportInfo()
+    [[nodiscard]] virtual const wangle::TransportInfo& getSetupTransportInfo()
         const noexcept = 0;
 
     virtual bool getCurrentTransportInfo(wangle::TransportInfo* tinfo) = 0;
 
     virtual void getFlowControlInfo(FlowControlInfo* info) = 0;
 
-    virtual HTTPTransaction::Transport::Type getSessionType()
+    [[nodiscard]] virtual HTTPTransaction::Transport::Type getSessionType()
         const noexcept = 0;
 
-    virtual const HTTPCodec& getCodec() const noexcept = 0;
+    [[nodiscard]] virtual const HTTPCodec& getCodec() const noexcept = 0;
 
     /*
      * Drain the underlying session. This will affect other transactions
@@ -526,33 +528,33 @@ class HTTPTransaction
      */
     virtual void drain() = 0;
 
-    virtual bool isDraining() const = 0;
+    [[nodiscard]] virtual bool isDraining() const = 0;
 
     virtual HTTPTransaction* newPushedTransaction(
         HTTPCodec::StreamID assocStreamId,
         HTTPTransaction::PushHandler* handler,
         ProxygenError* error = nullptr) noexcept = 0;
 
-    virtual std::string getSecurityProtocol() const = 0;
+    [[nodiscard]] virtual std::string getSecurityProtocol() const = 0;
 
     virtual void addWaitingForReplaySafety(
         folly::AsyncTransport::ReplaySafetyCallback* callback) noexcept = 0;
 
     virtual void removeWaitingForReplaySafety(
         folly::AsyncTransport::ReplaySafetyCallback* callback) noexcept = 0;
 
-    virtual bool needToBlockForReplaySafety() const = 0;
+    [[nodiscard]] virtual bool needToBlockForReplaySafety() const = 0;
 
-    virtual const folly::AsyncTransport* getUnderlyingTransport()
+    [[nodiscard]] virtual const folly::AsyncTransport* getUnderlyingTransport()
         const noexcept = 0;
 
     /**
      * Returns true if the underlying transport has completed full handshake.
      */
-    virtual bool isReplaySafe() const = 0;
+    [[nodiscard]] virtual bool isReplaySafe() const = 0;
 
     virtual void setHTTP2PrioritiesEnabled(bool enabled) = 0;
-    virtual bool getHTTP2PrioritiesEnabled() const = 0;
+    [[nodiscard]] virtual bool getHTTP2PrioritiesEnabled() const = 0;
 
     virtual HTTPSessionBase* getHTTPSessionBase() = 0;
 
@@ -563,7 +565,7 @@ class HTTPTransaction
       return folly::none;
     }
 
-    virtual uint16_t getDatagramSizeLimit() const noexcept {
+    [[nodiscard]] virtual uint16_t getDatagramSizeLimit() const noexcept {
       return 0;
     }
 
@@ -701,10 +703,10 @@ class HTTPTransaction
       folly::assume_unreachable();
     }
 
-    virtual folly::Optional<HTTPTransaction::ConnectionToken>
+    [[nodiscard]] virtual folly::Optional<HTTPTransaction::ConnectionToken>
     getConnectionToken() const noexcept = 0;
 
-    virtual bool serverEarlyResponseEnabled() const noexcept {
+    [[nodiscard]] virtual bool serverEarlyResponseEnabled() const noexcept {
       return false;
     }
   };

third-party/proxygen/src/proxygen/lib/http/session/SimpleController.h

@@ -52,7 +52,8 @@ class SimpleController : public HTTPSessionController {
   void attachSession(HTTPSessionBase*) override;
   void detachSession(const HTTPSessionBase*) override;
 
-  std::chrono::milliseconds getGracefulShutdownTimeout() const override;
+  [[nodiscard]] std::chrono::milliseconds getGracefulShutdownTimeout()
+      const override;
 
  protected:
   HTTPTransactionHandler* createErrorHandler(uint32_t statusCode,