Skip to content

Commit 18bfa17

Browse files
Vishwa Prakash Gayasenmeta-codesync[bot]
authored andcommitted
Remove lint suppressor for bidi
Summary: - Now that linter changes are pushed for bidi we don't need to suppress lint warnings - Removing it from thrift files to publish bidi being available in python Reviewed By: hchokshi Differential Revision: D90132736 fbshipit-source-id: eb4b9337bfcd018e1a0ccc98a94b0f3d93c614a9
1 parent 8f2fc5b commit 18bfa17

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

third-party/thrift/src/thrift/lib/python/test/bidi_service.thrift

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,12 @@ enum ThrowWhere {
6262
}
6363

6464
service TestBidiService {
65-
// @lint-ignore THRIFTCHECKS new unreleased feature
6665
sink<string>, stream<string> echo(1: double serverDelay);
6766

68-
// @lint-ignore THRIFTCHECKS new unreleased feature
6967
string, sink<string>, stream<string> echoWithResponse(1: string initial);
7068

71-
// @lint-ignore THRIFTCHECKS new unreleased feature
72-
sink<string>, stream<i32> intStream(double serverDelay);
69+
sink<string>, stream<i32> intStream(1: double serverDelay);
7370

74-
// @lint-ignore THRIFTCHECKS new unreleased feature
7571
FirstResponse, sink<SinkChunk>, stream<StreamChunk> structBidi(
7672
1: FirstRequest request,
7773
);
@@ -81,7 +77,6 @@ service TestBidiService {
8177
// if where is 1, throws on the stream before first chunk
8278
// if where is 2, throws on the stream after first chunk
8379
// otherwise, doesn't throw
84-
// @lint-ignore THRIFTCHECKS new unreleased feature
8580
sink<i64 throws (1: SinkException sinkEx)>, stream<
8681
i64 throws (1: StreamException streamEx)
8782
> canThrow(1: ThrowWhere where, 2: bool expected_throw) throws (

0 commit comments

Comments
 (0)