Remove some chained assignments from tests

Summary:
e.g., `$a = $b = f();` becomes
```
$b = $f();
$a = $b;
```
and
`$a = list ($b, $c) = f();`
becomes
```
$a = f();
list($b, $c);
```

We did this by having Claude write and apply a crappy codemod in D92297983 and then fixed things up by hand.

Reviewed By: nt591

Differential Revision: D92301393

fbshipit-source-id: 8eacc9995a699de729530db4196cb0dcf2f7e19f

Author: Scott Owens

hphp/test/quick/exception_many_locals.php

@@ -16,7 +16,12 @@ function main() :mixed{
     $o = new c;
     echo "Creating second c\n";
     $p = new c;
-    $o1 = $o2 = $o3 = $o4 = $o5 = $o6 = $o; // fill up caller-saved
+    $o6 = $o; //fill up caller-saved
+    $o5 = $o6;
+    $o4 = $o5;
+    $o3 = $o4;
+    $o2 = $o3;
+    $o1 = $o2;
     $o7 = $o; // use callee saved
     $p = 5;
     echo $x;

hphp/test/quick/generator_vars.php

@@ -63,7 +63,8 @@ function manylocals() :AsyncGenerator<mixed,mixed,void>{
   $a = yield dict['a' => $a, 'b' => $b, 'c' => $c, 'd' => $d, 'e' => $e, 'f' => $f, 'g' => $g, 'h' => $h, 'i' => $i, 'j' => $j, 'k' => $k, 'l' => $l];
   $b = 0xdeadbeef;
   $c = yield dict['a' => $a, 'b' => $b, 'c' => $c, 'd' => $d, 'e' => $e, 'f' => $f, 'g' => $g, 'h' => $h, 'i' => $i, 'j' => $j, 'k' => $k, 'l' => $l];
-  $d = $e = 0xba53b411;
+  $e = 0xba53b411;
+  $d = $e;
   yield dict['a' => $a, 'b' => $b, 'c' => $c, 'd' => $d, 'e' => $e, 'f' => $f, 'g' => $g, 'h' => $h, 'i' => $i, 'j' => $j, 'k' => $k, 'l' => $l];
 }
 

hphp/test/quick/many-clsrefs.php

@@ -14,10 +14,16 @@ class Bar {
   public static $prop10;
 
   static function set($f) :mixed{
-    self::$prop1 = self::$prop2 = self::$prop3 =
-    self::$prop4 = self::$prop5 = self::$prop6 =
-    self::$prop7 = self::$prop8 = self::$prop9 =
     self::$prop10 = $f();
+    self::$prop9 = self::$prop10;
+    self::$prop8 = self::$prop9;
+    self::$prop7 = self::$prop8;
+    self::$prop6 = self::$prop7;
+    self::$prop5 = self::$prop6;
+    self::$prop4 = self::$prop5;
+    self::$prop3 = self::$prop4;
+    self::$prop2 = self::$prop3;
+    self::$prop1 = self::$prop2;
   }
 
   static function dump() :mixed{

hphp/test/server/http/tests/hotswapTest.php

@@ -3,8 +3,10 @@
 function runHotswapTest() {
 
   $pid = posix_getpid();
-
-  $serverProc = $newServerProc = $serverPort = $adminPort = null;
+  $adminPort = null;
+  $serverPort = $adminPort;
+  $newServerProc = $serverPort;
+  $serverProc = $newServerProc;
   $debugPort = false;
   $serverHome = __DIR__.'/..';
   $serverRoot = __DIR__.'/../server_root';

hphp/test/slow/async/awaitall.php

@@ -93,7 +93,8 @@ function main_awaitall() :mixed{
   t($wh, $dicts);
 
   echo "grandchildren\n";
-  list($vecs, $dicts) = $handles = get_wrapped_handles();
+  $handles = get_wrapped_handles();
+  list($vecs, $dicts) = $handles;
 
   $top = vec[
     AwaitAllWaitHandle::fromVec(vec($vecs)),

hphp/test/slow/closure/1921.php

@@ -9,7 +9,8 @@ function foo() :mixed{
     } catch (UndefinedVariableException $e) {
       var_dump($e->getMessage());
     }
-    $abc = $var = 333;
+    $var = 333;
+    $abc = $var;
   };
   var_dump($a());
   var_dump($abc, $var);

hphp/test/slow/compilation/1261.php

@@ -6,6 +6,7 @@ class A {
  <<__EntryPoint>>
 function main_1261() :mixed{
 $a = new A();
- $a->a = $a->b = 'test';
+ $a->b = 'test';
+ $a->a = $a->b;
  var_dump($a);
 }

hphp/test/slow/compilation/1262.php

@@ -5,6 +5,7 @@
 function main_1262() :mixed{
 $a = 1;
  $a = dict[];
- $a['a'] = $a['b'] = 'test';
+ $a['b'] = 'test';
+ $a['a'] = $a['b'];
  var_dump($a);
 }

hphp/test/slow/dv_array/ext_imagick/010_importimagepixels.php

@@ -15,7 +15,8 @@
 
 /* Width and height. The area is amount of pixels divided
    by three. Three comes from 'RGB', three values per pixel */
-$width = $height = 100;
+$height = 100;
+$width = $height;
 
 /* Create empty image */
 $im = new Imagick();

hphp/test/slow/dv_array_hack_arr/ext_imagick/010_importimagepixels.php

@@ -15,7 +15,8 @@
 
 /* Width and height. The area is amount of pixels divided
    by three. Three comes from 'RGB', three values per pixel */
-$width = $height = 100;
+$height = 100;
+$width = $height;
 
 /* Create empty image */
 $im = new Imagick();