Commit 1fbb931
Fix flaky conformance tests: duplicate test cases, server stdout, nonconforming
Summary:
Fix conformance test flakiness across round-trip and RPC test suites (24 tests).
1. TestGenerator.cpp: The empty_optional test case was generated inside the
getInterestingValues() loop via addTestCase(), creating 30-50+ duplicate
test cases per map type. Each duplicate sent a separate request to the hack
conformance server, multiplying Queue Timeout failures. Moved the
empty_optional case outside the loop so it is generated exactly once per
type, matching the intended behavior.
2. conformance_server.py: Removed extra print('\n', flush=True) after port
output. When the parent process closes the stdout pipe after reading the
port, this extra write raised a BrokenPipeError causing the server to exit
before it could handle requests.
3. rpc_server.py: Removed embedded '\n' from the port print statement
(print(f"{addr.port}\n") -> print(addr.port)). The extra newline caused
the parent process to read an empty second line as the port, failing to
connect to the server.
4. nonconforming.txt: Added rust SinkDeclaredException test to the
nonconforming list, matching the existing SinkUndeclaredException entry.
This is a known runtime exception encoding non-conformance (T218969298).
Reviewed By: evanjzou
Differential Revision: D94987645
fbshipit-source-id: 1b93f4d909a77bf2634ac1333370452ef6a0c2d81 parent e1d242f commit 1fbb931
3 files changed
Lines changed: 14 additions & 7 deletions
File tree
- third-party/thrift/src/thrift/conformance
- data
- python
Lines changed: 13 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
81 | 88 | | |
82 | 89 | | |
83 | 90 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
88 | 96 | | |
89 | 97 | | |
90 | 98 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
0 commit comments