Commit 2b08d19
Remove redundant adapted serialized-size optimization
Summary:
Remove the arithmetic-adapter `serializedSizeFixed` specialization from
`Adapt.h`. Fixed-width protocol sizing ignores the converted value, and
optimized builds already eliminate a side-effect-free `toThrift` conversion
when its result is unused.
An opt-mode disassembly check used the production
`UnixTimestampThriftAdapter<std::chrono::microseconds>`. Its live conversion
compiled to 54 bytes including a multiply and shifts, while the
`serializedSizeI64` fallback compiled to the same 11-byte constant-return
sequence both with and without this specialization.
Reviewed By: hchokshi
Differential Revision: D116857994
fbshipit-source-id: 652f16879e9fe4757b5ead54cb306a79e68a80691 parent 76ebf2e commit 2b08d19
1 file changed
Lines changed: 0 additions & 59 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
545 | 545 | | |
546 | 546 | | |
547 | 547 | | |
548 | | - | |
549 | | - | |
550 | | - | |
551 | | - | |
552 | | - | |
553 | | - | |
554 | | - | |
555 | | - | |
556 | | - | |
557 | | - | |
558 | | - | |
559 | | - | |
560 | | - | |
561 | | - | |
562 | | - | |
563 | | - | |
564 | | - | |
565 | | - | |
566 | | - | |
567 | | - | |
568 | | - | |
569 | | - | |
570 | | - | |
571 | | - | |
572 | | - | |
573 | | - | |
574 | | - | |
575 | | - | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
580 | | - | |
581 | | - | |
582 | | - | |
583 | | - | |
584 | | - | |
585 | | - | |
586 | | - | |
587 | | - | |
588 | | - | |
589 | | - | |
590 | | - | |
591 | | - | |
592 | | - | |
593 | | - | |
594 | | - | |
595 | | - | |
596 | | - | |
597 | | - | |
598 | | - | |
599 | | - | |
600 | | - | |
601 | | - | |
602 | | - | |
603 | | - | |
604 | | - | |
605 | | - | |
606 | | - | |
607 | 548 | | |
608 | 549 | | |
609 | 550 | | |
| |||
0 commit comments