Add specify_implicit_func_param_id codemod

Summary: Add specify_implicit_func_param_id codemod

Reviewed By: aristidisp

Differential Revision: D90121162

fbshipit-source-id: 5cdfd2dda03cb27c164356ed1a9419d2ddf683f9

Author: Heejong Lee

third-party/thrift/src/thrift/compiler/codemod/specify_implicit_func_param_id.cc

@@ -0,0 +1,53 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <fmt/core.h>
+
+#include <thrift/compiler/ast/ast_visitor.h>
+#include <thrift/compiler/codemod/codemod.h>
+#include <thrift/compiler/codemod/file_manager.h>
+
+using apache::thrift::compiler::basic_ast_visitor;
+using apache::thrift::compiler::run_codemod;
+using apache::thrift::compiler::source_manager;
+using apache::thrift::compiler::t_field;
+using apache::thrift::compiler::t_program;
+using apache::thrift::compiler::t_program_bundle;
+using apache::thrift::compiler::codemod::file_manager;
+
+namespace {
+
+void specify_implicit_func_param_id(file_manager& fm, const t_field& f) {
+  if (f.explicit_id()) {
+    return;
+  }
+  auto loc = f.type().src_range().begin.offset();
+  fm.add({loc, loc, fmt::format("{}: ", f.id())});
+}
+
+} // namespace
+
+int main(int argc, char** argv) {
+  return apache::thrift::compiler::run_codemod(
+      argc, argv, [](source_manager& sm, t_program_bundle& pb) {
+        t_program& program = *pb.root_program();
+        basic_ast_visitor<true, file_manager&> visitor;
+        visitor.add_function_param_visitor(specify_implicit_func_param_id);
+        file_manager fm(sm, program);
+        visitor(fm, program);
+        fm.apply_replacements();
+      });
+}

third-party/thrift/src/thrift/compiler/codemod/specify_implicit_func_param_id_test.py

@@ -0,0 +1,113 @@
+# Copyright (c) Meta Platforms, Inc. and affiliates.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# pyre-unsafe
+
+import os
+import shutil
+import tempfile
+import textwrap
+import unittest
+
+import pkg_resources
+
+from xplat.thrift.compiler.codemod.test_utils import read_file, run_binary, write_file
+
+
+class SpecifyImplicitFuncParamIdTest(unittest.TestCase):
+    def setUp(self):
+        tmp = tempfile.mkdtemp()
+        self.addCleanup(shutil.rmtree, tmp, True)
+        self.tmp = tmp
+        self.addCleanup(os.chdir, os.getcwd())
+        os.chdir(self.tmp)
+        self.maxDiff = None
+
+    def test_basic_replace(self):
+        write_file(
+            "foo.thrift",
+            textwrap.dedent(
+                """\
+                struct Annotation {}
+
+                struct A {
+                    string foo;
+                }
+
+                service B1 {
+                    i32 bar(i32 a, i32 b);
+                }
+
+                service B2 {
+                    i32 bar(1: i32 a, i32 b);
+                }
+
+                service B3 {
+                    i32 bar(1: i32 a, i32 b, 2: i32 c, i32 d, 3: i32 e);
+                }
+
+                interaction C1 {
+                    void baz(i32 x);
+                }
+
+                interaction C2 {
+                    void baz(
+                        1: i32 x,
+                        2: i32 y,
+                        i32 z
+                    );
+                }
+                """
+            ),
+        )
+
+        binary = pkg_resources.resource_filename(__name__, "codemod")
+        run_binary(binary, "foo.thrift")
+
+        self.assertEqual(
+            read_file("foo.thrift"),
+            textwrap.dedent(
+                """\
+                struct Annotation {}
+
+                struct A {
+                    string foo;
+                }
+
+                service B1 {
+                    i32 bar(-1: i32 a, -2: i32 b);
+                }
+
+                service B2 {
+                    i32 bar(1: i32 a, -1: i32 b);
+                }
+
+                service B3 {
+                    i32 bar(1: i32 a, -1: i32 b, 2: i32 c, -2: i32 d, 3: i32 e);
+                }
+
+                interaction C1 {
+                    void baz(-1: i32 x);
+                }
+
+                interaction C2 {
+                    void baz(
+                        1: i32 x,
+                        2: i32 y,
+                        -1: i32 z
+                    );
+                }
+                """
+            ),
+        )