Fix CQS signal modernize-use-emplace in fbcode/mcrouter/lib

Differential Revision: D96109484

fbshipit-source-id: c686048cc241ea81490297738f73620d663e4683

Author: generatedunixname1587093422349604

third-party/mcrouter/src/mcrouter/lib/fbi/test/sem_test.cpp

@@ -53,10 +53,10 @@ TEST(counting_semaphore, basic) {
 
   std::vector<std::thread> threads;
   for (int i = 0; i < Y; ++i) {
-    threads.push_back(std::thread{&consume, i, X});
+    threads.emplace_back(&consume, i, X);
   }
   for (int i = 0; i < X; ++i) {
-    threads.push_back(std::thread{&produce, i, Y});
+    threads.emplace_back(&produce, i, Y);
   }
 
   for (auto& t : threads) {
@@ -77,10 +77,10 @@ TEST(counting_semaphore, nonblocking) {
 
   std::vector<std::thread> threads;
   for (int i = 0; i < X; ++i) {
-    threads.push_back(std::thread{&produce, i, Y});
+    threads.emplace_back(&produce, i, Y);
   }
   for (int i = 0; i < Y; ++i) {
-    threads.push_back(std::thread{&consume_nonblocking, i, X});
+    threads.emplace_back(&consume_nonblocking, i, X);
   }
 
   for (auto& t : threads) {