Skip to content

Commit 3f32f22

Browse files
mheibermeta-codesync[bot]
authored andcommitted
ServerFindMyTests: back to 0 dependencies alerts
Summary: ## What Fix it so our builds no longer show a "dependencies" alert. **Before** ``` [mheiber@devbig197]~/fbsource/fbcode/hphp/hack% dune clean && dune build single Entering directory '/data/users/mheiber/fbsource/fbcode/hphp' File "hack/src/server/serverFindMyTests.ml", line 42, characters 8-31: 42 | match Decl_provider.get_class ctx (Utils.add_ns class_name) with ^^^^^^^^^^^^^^^^^^^^^^^ Alert dependencies: Decl_provider.get_class ``` **After** ``` [mheiber@devbig197]~/fbsource/fbcode/hphp/hack% dune clean && dune build single ``` This version of the diff has TODO for explaining why we suppress the alert. Hoping reviewers (frankemrich) can help guide to what the TODO should say or suggest the best fix. ## Context - decl_provider.mli and folded_class.mli have alerts that say not to use certain functions which are not fanout-aware and to use typing_env.mli functions instead - serverFindMyTests.ml currently violates this Differential Revision: D90113599 fbshipit-source-id: 802f9ce86c1e8dc9caaa296c6f078635b66b3792
1 parent 2164fb3 commit 3f32f22

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

hphp/hack/src/server/serverFindMyTests.ml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@
99
open Hh_prelude
1010
open ServerEnv
1111

12+
[@@@alert "-dependencies"]
13+
(* TODO: either use fanout-aware functions from typing env
14+
* or update this comment to say why we don't need them
15+
*)
16+
1217
type member = Method of string
1318

1419
let findrefs_member_of_member = function

0 commit comments

Comments
 (0)