Migrate hphp/ from Clap 3 to Clap 4

Summary:
This is a Claude Code generated diff stack to migrate all existing users of Clap 3 to Clap 4. It follows CLI Foundation ["Clap 4 Migration"](https://www.internalfb.com/wiki/CLI_Foundation/Guidelines_&_How_To/Frameworks_&_Main_Libraries/Rust/Clap_4_Migration/) wiki and "clap4-migration" Claude skill based on it and the Clap changelogs.

[Clap 2 and 3 have been deprecated for over 3 years.](https://fb.workplace.com/groups/clifoundation/posts/753507606006249/) They will be deleted soon and this should make it much easier for everyone to move over.

Sandcastle should be green indicating that the CLI builds succesfully and any tests related should be good too. Considering there are over a hundred CLIs using Clap 2 and 3, this as good of a signal we are able of getting. If you need more signal, we highly recommend you to look into [Scrut](https://www.internalfb.com/intern/staticdocs/scrut/docs/), an end-to-end CLI testing toolkit. Though this is outside of the scope for this massive diff stack.

If you want additional assurances that you can roll back. You might want to have a look at [`cli.deployer`](https://www.internalfb.com/wiki/Cli.deployer/)

**Please make sure to review the diff in case of any issues. There might be some slight changes to the CLI due to the large amount of changes that have been seen in Clap over the last years. If you want to make further changes, please make a new diff rebased on this one and they can land them together.**

 ---

Migrate 13 BUCK file(s) in hphp/ from clap-3 to clap (Clap 4).

Reviewed By: dtolnay

Differential Revision: D93109006

fbshipit-source-id: 268d5cf7da6bbeaad5f799968be449d275256738

Author: AndreasBackx

hphp/hack/src/Cargo.lock

@@ -13,5 +13,5 @@ path = "lrgen.rs"
 
 [dependencies]
 cfgrammar = { version = "0.12", features = ["serde"] }
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
 lrlex = "0.12"

hphp/hack/src/asdl_to_rust/lrgen/Cargo.toml

@@ -12,5 +12,5 @@ name = "depgraph_decompress"
 path = "../../main.rs"
 
 [dependencies]
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
 decompress = { version = "0.0.0", path = "../../decompress" }

hphp/hack/src/depgraph/depgraph_decompress/cargo/depgraph_decompress/Cargo.toml

@@ -13,7 +13,7 @@ path = "../../hhdg.rs"
 
 [dependencies]
 anyhow = "1.0.98"
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
 depgraph_reader = { version = "0.0.0", path = "../../../cargo/depgraph_reader" }
 hash = { version = "0.0.0", path = "../../../../utils/hash" }
 human_readable_dep_map = { version = "0.0.0", path = "../../../cargo/human_readable_dep_map" }

hphp/hack/src/depgraph/hhdg/cargo/hhdg/Cargo.toml

@@ -13,5 +13,5 @@ path = "../../generate_hhi.rs"
 
 [dependencies]
 anyhow = "1.0.98"
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
 generate_hhi_lib = { version = "0.0.0", path = "../generate_hhi_lib" }

hphp/hack/src/generate_hhi/cargo/generate_hhi/Cargo.toml

@@ -9,5 +9,5 @@ license = "MIT"
 
 [dependencies]
 anyhow = "1.0.98"
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
 pulldown-cmark = "0.13.0"

hphp/hack/src/hh_manual/Cargo.toml

@@ -16,7 +16,7 @@ path = "hh_naming_table_builder.rs"
 
 [dependencies]
 anyhow = "1.0.98"
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
 direct_decl_parser = { version = "0.0.0", path = "../parser/api/cargo/direct_decl_parser" }
 files_to_ignore = { version = "0.0.0", path = "../utils/files_to_ignore" }
 find_utils = { version = "0.0.0", path = "../utils/find_utils" }

hphp/hack/src/hh_naming_table_builder/Cargo.toml

@@ -13,7 +13,7 @@ test = false
 doctest = false
 
 [build-dependencies]
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
 gen_hhi_contents_lib = { version = "0.0.0", path = "cargo/gen_hhi_contents_lib" }
 generate_hhi_lib = { version = "0.0.0", path = "../../generate_hhi/cargo/generate_hhi_lib" }
 walkdir = "2.3"

hphp/hack/src/hhi/rust/Cargo.toml

@@ -14,7 +14,7 @@ path = "../src/rust_to_ocaml.rs"
 [dependencies]
 anyhow = "1.0.98"
 attr_parser = { version = "0.0.0", path = "../attr_parser" }
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }
 convert_case = "0.10.0"
 derive_more = { version = "1.0.0", features = ["full"] }
 indexmap = { version = "2.13.0", features = ["arbitrary", "rayon", "serde"] }

hphp/hack/src/rust_to_ocaml/rust_to_ocaml/Cargo.toml

@@ -14,4 +14,4 @@ path = "ffi_cbindgen.rs"
 [dependencies]
 anyhow = "1.0.98"
 cbindgen = "0.28.0"
-clap = { version = "3.2.25", features = ["derive", "env", "regex", "unicode", "wrap_help"] }
+clap = { version = "4.5.42", features = ["derive", "env", "string", "unicode", "wrap_help"] }