add feature flag ExpressionTreeShapeCreation

Summary: Per parent diff review, introduced `expression_tree_shape_creation` feature flag to only support shape syntax in preview mode.

Reviewed By: dlreeves

Differential Revision: D68829046

fbshipit-source-id: 6d6247ef2925fc87c3bbdc9172beb0159614c2b2

Author: Michel Weststrate

hphp/hack/src/options/experimental_features.ml

@@ -66,6 +66,7 @@ type feature_name =
   | ExpressionTreeNestedBindings
   | LikeTypeHints
   | ShapeDestructure
+  | ExpressionTreeShapeCreation
 [@@deriving eq, ord, show]
 
 let feature_name_map =
@@ -108,6 +109,7 @@ let feature_name_map =
       ("expression_tree_nested_bindings", ExpressionTreeNestedBindings);
       ("like_type_hints", LikeTypeHints);
       ("shape_destructure", ShapeDestructure);
+      ("expression_tree_shape_creation", ExpressionTreeShapeCreation);
     ]
 
 let feature_name_from_string s = SMap.find_opt s feature_name_map

hphp/hack/src/options/experimental_features.mli

@@ -60,6 +60,7 @@ type feature_name =
   | ExpressionTreeNestedBindings
   | LikeTypeHints
   | ShapeDestructure
+  | ExpressionTreeShapeCreation
 [@@deriving eq, ord, show]
 
 val feature_status_from_string : string -> feature_status option

hphp/hack/src/oxidized/gen/experimental_features.rs

@@ -3,7 +3,7 @@
 // This source code is licensed under the MIT license found in the
 // LICENSE file in the "hack" directory of this source tree.
 //
-// @generated SignedSource<<9627bbf2ac863eec80ce4134d9c2b60f>>
+// @generated SignedSource<<bd2fad7e13f706aa5d3dcdc649b868e8>>
 //
 // To regenerate this file, run:
 //   hphp/hack/src/oxidized_regen.sh
@@ -114,6 +114,7 @@ pub enum FeatureName {
     ExpressionTreeNestedBindings,
     LikeTypeHints,
     ShapeDestructure,
+    ExpressionTreeShapeCreation,
 }
 impl TrivialDrop for FeatureName {}
 arena_deserializer::impl_deserialize_in_arena!(FeatureName);

hphp/hack/src/oxidized/manual/experimental_features_impl.rs

@@ -51,6 +51,7 @@ impl FeatureName {
             ExpressionTreeNestedBindings => Unstable,
             LikeTypeHints => Unstable,
             ShapeDestructure => Unstable,
+            ExpressionTreeShapeCreation => Preview,
         }
     }
 

hphp/hack/src/parser/rust_parser_errors.rs

@@ -3266,6 +3266,9 @@ impl<'a, State: 'a + Clone> ParserErrors<'a, State> {
                 }
             }
             ShapeExpression(x) => {
+                if self.context.active_expression_tree {
+                    self.check_can_use_feature(node, &FeatureName::ExpressionTreeShapeCreation)
+                }
                 for f in syntax_to_list_no_separators(&x.fields).rev() {
                     self.invalid_shape_field_check(f)
                 }

hphp/hack/test/expr_tree_debug_print/shape_param.good.php

@@ -1,5 +1,5 @@
 <?hh
-<<file:__EnableUnstableFeatures('expression_trees')>>
+<<file:__EnableUnstableFeatures('expression_trees', 'expression_tree_shape_creation')>>
 
 function g(): void {
   ExampleDsl`{

hphp/hack/test/expr_tree_debug_print/shape_param.good.php.exp

@@ -1,5 +1,9 @@
 <?hh
-<<file: __EnableUnstableFeatures('expression_trees')>>
+<<file:
+  __EnableUnstableFeatures(
+    'expression_trees',
+    'expression_tree_shape_creation',
+  )>>
 
 function g(): void {
   ExampleDsl::makeTree(

hphp/test/slow/expression_trees/shape.php

@@ -1,6 +1,6 @@
 <?hh
 
-<<file:__EnableUnstableFeatures('expression_trees')>>
+<<file:__EnableUnstableFeatures('expression_trees', 'expression_tree_shape_creation')>>
 
 <<__EntryPoint>>
 function test(): void {