Migrate class/field name from legacy reflection to always-on reflection in unit-test

Reviewed By: aristidisp

Differential Revision: D90030432

fbshipit-source-id: dfc8a2d6509cddd1f451606766058d86a4ccff58

Author: Mizuchi

third-party/thrift/src/thrift/lib/cpp2/reflection/internal/legacy_reflection-inl-post.h

@@ -238,11 +238,10 @@ struct impl<T, type_class::structure> {
       using type = deref_inner_t<decltype(getter{}(std::declval<T&>()))>;
       using type_class = typename MemberInfo::type_class;
       using type_helper = get_helper<type, type_class>;
-      using member_name = typename MemberInfo::name;
       using member_annotations = typename MemberInfo::annotations::map;
       type_helper::register_into(schema);
       auto& f = (*dt.fields())[MemberInfo::id::value];
-      std::string name = fatal::to_instance<std::string, member_name>();
+      std::string name = MemberInfo::name_v.str();
       impl_structure_util::init(
           f,
           type_helper::id(),

third-party/thrift/src/thrift/test/benchmarks/reflection_benchmark.cpp

@@ -77,7 +77,7 @@ void add_benchmark() {
       int k = 0;
       fatal::foreach<typename reflect_struct<Struct>::members>([&k](auto tag) {
         using Member = decltype(fatal::tag_type(tag));
-        const char* name = fatal::z_data<typename Member::name>();
+        const char* name = Member::name_v.data();
         for (char c : std::string_view(name)) {
           k += c;
         }