Fix CQS signal modernize-pass-by-value in fbcode/proxygen/httpclient

Reviewed By: hanidamlaj

Differential Revision: D89646895

fbshipit-source-id: f80e457686b4667066ed2297f12e8e356ea36965

Author: generatedunixname89002005287564

third-party/proxygen/src/proxygen/httpclient/samples/curl/CurlClient.cpp

@@ -10,6 +10,7 @@
 
 #include <iostream>
 #include <sys/stat.h>
+#include <utility>
 
 #include <folly/FileUtil.h>
 #include <folly/String.h>
@@ -30,17 +31,17 @@ namespace CurlService {
 
 CurlClient::CurlClient(EventBase* evb,
                        HTTPMethod httpMethod,
-                       const URL& url,
+                       URL url,
                        const proxygen::URL* proxy,
                        const HTTPHeaders& headers,
-                       const string& inputFilename,
+                       string inputFilename,
                        bool h2c,
                        unsigned short httpMajor,
                        unsigned short httpMinor)
     : evb_(evb),
       httpMethod_(httpMethod),
-      url_(url),
-      inputFilename_(inputFilename),
+      url_(std::move(url)),
+      inputFilename_(std::move(inputFilename)),
       h2c_(h2c),
       httpMajor_(httpMajor),
       httpMinor_(httpMinor) {

third-party/proxygen/src/proxygen/httpclient/samples/curl/CurlClient.h

@@ -68,10 +68,10 @@ class CurlClient
  public:
   CurlClient(folly::EventBase* evb,
              proxygen::HTTPMethod httpMethod,
-             const proxygen::URL& url,
+             proxygen::URL url,
              const proxygen::URL* proxy,
              const proxygen::HTTPHeaders& headers,
-             const std::string& inputFilename,
+             std::string inputFilename,
              bool h2c = false,
              unsigned short httpMajor = 1,
              unsigned short httpMinor = 1);

third-party/proxygen/src/proxygen/httpclient/samples/websocket/WebSocketClient.cpp

@@ -18,8 +18,8 @@ using namespace std;
 
 namespace websocketclient {
 
-WebSocketClient::WebSocketClient(EventBase* evb, const proxygen::URL& url)
-    : evb_(evb), url_(url) {
+WebSocketClient::WebSocketClient(EventBase* evb, proxygen::URL url)
+    : evb_(evb), url_(std::move(url)) {
 }
 
 void WebSocketClient::connectSuccess(HTTPUpstreamSession* session) {

third-party/proxygen/src/proxygen/httpclient/samples/websocket/WebSocketClient.h

@@ -20,7 +20,7 @@ class WebSocketClient
     , public proxygen::HTTPTransactionHandler {
 
  public:
-  WebSocketClient(folly::EventBase* evb, const proxygen::URL& url);
+  WebSocketClient(folly::EventBase* evb, proxygen::URL url);
 
   ~WebSocketClient() override = default;