Skip to content

Commit 825d356

Browse files
afrindmeta-codesync[bot]
authored andcommitted
Remove all mentions of boost
Summary: proxygen no longer directly requires boost Reviewed By: jbeshay Differential Revision: D93943200 fbshipit-source-id: 1371093607df2697771187df2088253609686e8a
1 parent a354701 commit 825d356

5 files changed

Lines changed: 3 additions & 14 deletions

File tree

third-party/proxygen/src/cmake/proxygen-config.cmake.in

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,6 @@ find_dependency(Fizz)
3232
find_dependency(ZLIB)
3333
find_dependency(OpenSSL)
3434
find_dependency(Threads)
35-
find_dependency(Boost 1.69 REQUIRED
36-
COMPONENTS
37-
iostreams
38-
context
39-
filesystem
40-
program_options
41-
regex
42-
thread
43-
)
4435
find_dependency(c-ares REQUIRED)
4536

4637
if(NOT TARGET proxygen::proxygen)

third-party/proxygen/src/proxygen/lib/http/HTTPHeaders.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class HTTPHeaders {
209209
* hdrs.removeByPredicate([&] (HTTPHeaderCode code,
210210
* const string& header,
211211
* const string& val) {
212-
* return boost::regex_match(header, "^X-Fb-.*");
212+
* return std::regex_match(header, std::regex("^X-Fb-.*"));
213213
* });
214214
*
215215
* return true only if one or more headers are removed.

third-party/proxygen/src/proxygen/lib/http/HTTPMessage.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ void HTTPMessage::splitNameValuePieces(
697697
}
698698

699699
StringPiece HTTPMessage::trim(StringPiece sp) {
700-
// TODO: use a library function from boost?
700+
// TODO: use a library trim function?
701701
for (; !sp.empty() && sp.front() == ' '; sp.pop_front()) {
702702
}
703703
for (; !sp.empty() && sp.back() == ' '; sp.pop_back()) {

third-party/proxygen/src/proxygen/lib/http/session/HTTP2PriorityQueue.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,6 @@ class HTTP2PriorityQueue : public HTTP2PriorityQueueBase {
215215
void updateEnqueuedWeight();
216216

217217
private:
218-
using link_mode = boost::intrusive::link_mode<boost::intrusive::auto_unlink>;
219-
220218
class Node
221219
: public BaseNode
222220
, public folly::HHWheelTimer::Callback {

third-party/proxygen/src/proxygen/lib/utils/test/GenericFilterTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ using std::unique_ptr;
2020

2121
namespace detail {
2222

23-
// This is defined in boost 1.53, but we only have 1.51 so far
23+
// Helper to get a raw pointer from a unique_ptr
2424

2525
template <typename T>
2626
T* get_pointer(const unique_ptr<T>& ptr) {

0 commit comments

Comments
 (0)