Skip to content

Commit 82e96d2

Browse files
rexzhang123meta-codesync[bot]
authored andcommitted
Convert 7 more portability targets with all deps in exported_deps
Summary: Convert asm, atomic, dirent, fcntl, fmt_compile, memory, sched from dual fbcode_target/non_fbcode_target to fb_dirsync_cpp_library. These targets were skipped by --conservative mode in last diff because their fbcode and xplat definitions had different deps/exported_deps splits (e.g., :sockets was private in fbcode but exported in xplat). fix: put ALL deps from both definitions into exported_deps. This is strictly more permissive — consumers get more transitive visibility, not less — so nothing breaks. This is on the path to removing dirsync entirely — there's no reason to keep it anymore. Removing it would significantly reduce code complexity and developer cognitive overhead. https://fb.workplace.com/groups/fbsource.dev/permalink/3906759792803147/ Reviewed By: mzlee Differential Revision: D94741336 fbshipit-source-id: 2bc9a59d7696c8022b72eb4a748ca8c8f74a7f10
1 parent 5debf0c commit 82e96d2

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

third-party/folly/src/folly/portability/CMakeLists.txt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ folly_add_library(
6565
Dirent.cpp
6666
HEADERS
6767
Dirent.h
68-
DEPS
68+
EXPORTED_DEPS
6969
folly_portability_windows
7070
)
7171

@@ -85,11 +85,10 @@ folly_add_library(
8585
Fcntl.cpp
8686
HEADERS
8787
Fcntl.h
88-
DEPS
89-
folly_portability_sockets
90-
folly_portability_sys_stat
9188
EXPORTED_DEPS
9289
folly_portability
90+
folly_portability_sockets
91+
folly_portability_sys_stat
9392
folly_portability_windows
9493
)
9594

0 commit comments

Comments
 (0)