Commit 82e96d2
Convert 7 more portability targets with all deps in exported_deps
Summary:
Convert asm, atomic, dirent, fcntl, fmt_compile, memory, sched from
dual fbcode_target/non_fbcode_target to fb_dirsync_cpp_library.
These targets were skipped by --conservative mode in last diff because their
fbcode and xplat definitions had different deps/exported_deps splits
(e.g., :sockets was private in fbcode but exported in xplat).
fix: put ALL deps from both definitions into exported_deps. This is
strictly more permissive — consumers get more transitive visibility,
not less — so nothing breaks.
This is on the path to removing dirsync entirely — there's no reason to keep it anymore. Removing it would significantly reduce code complexity and developer cognitive overhead.
https://fb.workplace.com/groups/fbsource.dev/permalink/3906759792803147/
Reviewed By: mzlee
Differential Revision: D94741336
fbshipit-source-id: 2bc9a59d7696c8022b72eb4a748ca8c8f74a7f101 parent 5debf0c commit 82e96d2
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | 88 | | |
92 | 89 | | |
| 90 | + | |
| 91 | + | |
93 | 92 | | |
94 | 93 | | |
95 | 94 | | |
| |||
0 commit comments