Skip to content

Commit 87e3a5b

Browse files
John Oxleyfacebook-github-bot
John Oxley
authored andcommitted
Fix docs for ExportedHistogram
Summary: `ExportedHistogram` wraps `folly::Histogram`. From the folly docs https://www.internalfb.com/code/fbsource/[0f0c602d3bc63b33d7b8554fa5976ceb612d4e2b]/fbcode/folly/docs/Histogram.md?lines=54-63 and https://www.internalfb.com/code/fbsource/[d81cb3266ebe564aa44fb290afc21dbc892eaac8]/fbcode/folly/stats/Histogram.h?lines=50-59 The docstring in HHVM for `bucketSize` is incorrect and led to a significant delay in understanding what was wrong. Reviewed By: mdko Differential Revision: D68882151 fbshipit-source-id: 04f332e7ed43dad7d0811840f55b0978e194576e
1 parent a3c9933 commit 87e3a5b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

hphp/util/service-data.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,9 @@ ExportedTimeSeries* createTimeSeries(
211211
/*
212212
* Create a histogram counter named 'name'. Return an existing one if it has
213213
* already been created.
214+
* The number of buckets is (max - min) / bucketSize
214215
*
215-
* 'bucketSize' specifies how many buckets to track for the histogram.
216+
* 'bucketSize' specifies the size of each bucket
216217
* 'min' is the minimal value in the histogram.
217218
* 'max' is the maximal value in the histogram.
218219
* 'exportPercentile' specifies at what percentile values we should report the

0 commit comments

Comments
 (0)