Skip to content

Commit 953167b

Browse files
yfeldblummeta-codesync[bot]
authored andcommitted
use explicit types in Cursor::write (assorted)
Summary: Addresses problems like this: ``` void* buf = /*...*/; uint16_t word = /*...*/; cursor.write(word & 0xffff); // oops, 32-bit store due to implicit integer promotion ``` Reviewed By: jupp0r Differential Revision: D94252965 fbshipit-source-id: 7144f7410838bf23976155348ecf1293c1ecb18d
1 parent 1f16513 commit 953167b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

hphp/runtime/server/fastcgi/fastcgi-session.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -622,10 +622,10 @@ void FastCGISession::writeCapability(const std::string& key) {
622622
auto appendLength = [&] (const std::string& lenStr) {
623623
if (lenStr.size() > 255) {
624624
len += sizeof(uint32_t);
625-
cursor.writeBE<uint32_t>(lenStr.size() | (0x80 << 24));
625+
cursor.writeBE<uint32_t>(static_cast<uint32_t>(lenStr.size() | (0x80 << 24)));
626626
} else {
627627
len += sizeof(uint8_t);
628-
cursor.writeBE<uint8_t>(lenStr.size());
628+
cursor.writeBE<uint8_t>(static_cast<uint8_t>(lenStr.size()));
629629
}
630630
};
631631

0 commit comments

Comments
 (0)